go/gorocket
1
0
Fork 0
mirror of https://github.com/badkaktus/gorocket.git synced 2025-07-13 01:10:14 +02:00
Code Issues Releases Activity

Do not exit the program on failed API Calls, return an error instead

Browse Source 
Using log.Fatal() calls os.Exit(1) after the log message is printed.
os.Exit cannot be catched and exits the program without giving the
user a chance to recover from the error.
This commit is contained in:
Thomas Buchinger
2022-03-07 13:14:14 +01:00
parent 20b58b835e
commit c0295b8976
2 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
gorocket.go
View File

@ -36,18 +36,13 @@ func (c *Client) sendRequest(req *http.Request, v interface{}) error {
res, err := c.HTTPClient.Do(req) res, err := c.HTTPClient.Do(req)
if err != nil { if err != nil {
log.Fatal(err) log.Println(err)
return err
} }
defer res.Body.Close() defer res.Body.Close()
// body, err := ioutil.ReadAll(res.Body)
//fmt.Println(string(body))
//if err != nil {
// log.Fatal(err)
//}
resp := v resp := v
if err = json.NewDecoder(res.Body).Decode(&resp); err != nil { if err = json.NewDecoder(res.Body).Decode(&resp); err != nil {
return err return err
} }

6
hooks.go
View File

@ -40,7 +40,8 @@ func (c *Client) Hooks(msg *HookMessage, token string) (*HookResponse, error) {
req.Header.Set("Content-Type", "application/json; charset=utf-8") req.Header.Set("Content-Type", "application/json; charset=utf-8")
if err != nil { if err != nil {
log.Fatal("Request error") log.Println("Request error")
return nil, err
} }
res, err := c.HTTPClient.Do(req) res, err := c.HTTPClient.Do(req)
@ -48,7 +49,8 @@ func (c *Client) Hooks(msg *HookMessage, token string) (*HookResponse, error) {
defer res.Body.Close() defer res.Body.Close()
if err != nil { if err != nil {
log.Fatal(err) log.Println(err)
return nil, err
} }
resp := HookResponse{} resp := HookResponse{}