go/gosec
1
0
Fork 0
mirror of https://github.com/securego/gosec.git synced 2025-06-16 23:47:51 +02:00
Code Issues Releases Activity

Fix wrong location for G109 (#829)

Browse Source 
Before this commit, G109 will report on `strconv.Atoi`.
After this, it will report on the convertion like`int32(a)`.
This commit is contained in:
云微
2022-07-06 12:37:11 +08:00
committed by GitHub
parent 7dd9ddd583
commit 602ced7e71
2 changed files with 20 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
rules/integer_overflow.go
View File

@ -61,7 +61,7 @@ func (i *integerOverflowCheck) Match(node ast.Node, ctx *gosec.Context) (*gosec.
if fun, ok := n.Fun.(*ast.Ident); ok {
if fun.Name == "int32" || fun.Name == "int16" {
if idt, ok := n.Args[0].(*ast.Ident); ok {
if n, ok := atoiVarObj[idt.Obj]; ok {
if _, ok := atoiVarObj[idt.Obj]; ok {
// Detect int32(v) and int16(v)
return gosec.NewIssue(ctx, n, i.ID(), i.What, i.Severity, i.Confidence), nil
}