go/gosec
1
0
Fork 0
mirror of https://github.com/securego/gosec.git synced 2025-07-15 01:04:43 +02:00
Code Issues Releases Activity

Add null pointer check in G601

Browse Source 
fixes: #475
This commit is contained in:
Grant Murphy
2020-05-21 01:17:44 +10:00
committed by Cosmin Cojocar
parent 1418b856ea
commit 8630c43b66
3 changed files with 36 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
rules/implicit_aliasing.go
View File

@ -2,9 +2,10 @@ package rules
import (
"fmt"
"github.com/securego/gosec/v2"
"go/ast"
"go/token"
"github.com/securego/gosec/v2"
)
type implicitAliasing struct {
@ -33,20 +34,23 @@ func (r *implicitAliasing) Match(n ast.Node, c *gosec.Context) (*gosec.Issue, er
// When presented with a range statement, get the underlying Object bound to
// by assignment and add it to our set (r.aliases) of objects to check for.
if key, ok := node.Value.(*ast.Ident); ok {
if assignment, ok := key.Obj.Decl.(*ast.AssignStmt); ok {
if len(assignment.Lhs) < 2 {
return nil, nil
}
if key.Obj != nil {
if assignment, ok := key.Obj.Decl.(*ast.AssignStmt); ok {
if len(assignment.Lhs) < 2 {
return nil, nil
}
if object, ok := assignment.Lhs[1].(*ast.Ident); ok {
r.aliases[object.Obj] = struct{}{}
if object, ok := assignment.Lhs[1].(*ast.Ident); ok {
r.aliases[object.Obj] = struct{}{}
if r.rightBrace < node.Body.Rbrace {
r.rightBrace = node.Body.Rbrace
if r.rightBrace < node.Body.Rbrace {
r.rightBrace = node.Body.Rbrace
}
}
}
}
}
case *ast.UnaryExpr:
// If this unary expression is outside of the last range statement we were looking at
// then clear the list of objects we're concerned about because they're no longer in