1
0
mirror of https://github.com/securego/gosec.git synced 2025-07-15 01:04:43 +02:00

Fix for G402. Check package path instead of package name (#838)

This commit is contained in:
Dmitry Golushko
2022-07-28 08:51:30 +02:00
committed by GitHub
parent ea6d49d1b5
commit a5982fb6a6
3 changed files with 48 additions and 9 deletions

View File

@ -39,7 +39,10 @@ import (
func MatchCallByPackage(n ast.Node, c *Context, pkg string, names ...string) (*ast.CallExpr, bool) {
importedName, found := GetImportedName(pkg, c)
if !found {
return nil, false
importedName, found = GetAliasedName(pkg, c)
if !found {
return nil, false
}
}
if callExpr, ok := n.(*ast.CallExpr); ok {
@ -245,7 +248,7 @@ func GetBinaryExprOperands(be *ast.BinaryExpr) []ast.Node {
}
// GetImportedName returns the name used for the package within the
// code. It will resolve aliases and ignores initialization only imports.
// code. It will ignore initialization only imports.
func GetImportedName(path string, ctx *Context) (string, bool) {
importName, imported := ctx.Imports.Imported[path]
if !imported {
@ -256,20 +259,39 @@ func GetImportedName(path string, ctx *Context) (string, bool) {
return "", false
}
if alias, ok := ctx.Imports.Aliased[path]; ok {
importName = alias
return importName, true
}
// GetAliasedName returns the aliased name used for the package within the
// code. It will ignore initialization only imports.
func GetAliasedName(path string, ctx *Context) (string, bool) {
importName, imported := ctx.Imports.Aliased[path]
if !imported {
return "", false
}
if _, initonly := ctx.Imports.InitOnly[path]; initonly {
return "", false
}
return importName, true
}
// GetImportPath resolves the full import path of an identifier based on
// the imports in the current context.
// the imports in the current context(including aliases).
func GetImportPath(name string, ctx *Context) (string, bool) {
for path := range ctx.Imports.Imported {
if imported, ok := GetImportedName(path, ctx); ok && imported == name {
return path, true
}
}
for path := range ctx.Imports.Aliased {
if imported, ok := GetAliasedName(path, ctx); ok && imported == name {
return path, true
}
}
return "", false
}