go/gosec
1
0
Fork 0
mirror of https://github.com/securego/gosec.git synced 2025-11-25 22:22:17 +02:00
Code Issues Releases Activity

refactor(G304): remove unused trackJoin helper; no functional change

Browse Source
This commit is contained in:
Eshani Parulekar
2025-09-12 19:05:58 +05:30
committed by Cosmin Cojocar
parent ab078db7b0
commit e81fba3c3a
1 changed files with 0 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
rules/readfile.go
View File

@@ -94,19 +94,6 @@ func (r *readfile) trackFilepathClean(n ast.Node) {
} }
} }
// trackJoin records when a Join() call result is assigned to an identifier
// example: fullPath := filepath.Join(baseDir, cleanPath)
func (r *readfile) trackJoin(n ast.Node) {
// n is expected to be a *ast.CallExpr (Join(...)) but the assignment is a different node.
// We will look for an enclosing AssignStmt if provided (the caller passes n which is the call)
if joinCall, ok := n.(*ast.CallExpr); ok && len(joinCall.Args) > 0 {
// We don't have direct access to the enclosing assignment here (since Match receives call exprs),
// so the practical approach is: when Match sees a Join call used in an assignment, it should call this helper
// with the assignment node. For simplicity, we will expect the caller to pass an AssignStmt.
_ = joinCall // caller should call trackJoin on the AssignStmt (see Match where we call it)
}
}
// trackJoinAssignStmt tracks assignments where RHS is a Join(...) call and LHS is an identifier // trackJoinAssignStmt tracks assignments where RHS is a Join(...) call and LHS is an identifier
func (r *readfile) trackJoinAssignStmt(node *ast.AssignStmt, c *gosec.Context) { func (r *readfile) trackJoinAssignStmt(node *ast.AssignStmt, c *gosec.Context) {
if len(node.Rhs) == 0 { if len(node.Rhs) == 0 {