go/gosec
1
0
Fork 0
mirror of https://github.com/securego/gosec.git synced 2025-11-23 22:15:04 +02:00
Code Issues Releases Activity

Check nil pointer when variable is declared in a different file

Browse Source
This commit is contained in:
Rick Moran
2023-03-08 08:42:45 -05:00
committed by GitHub
parent cdd3476f91
commit f823a7e92b
3 changed files with 60 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
rules/readfile.go
View File

@@ -81,7 +81,11 @@ func (r *readfile) isFilepathClean(n *ast.Ident, c *gosec.Context) bool {
func (r *readfile) trackFilepathClean(n ast.Node) {
if clean, ok := n.(*ast.CallExpr); ok && len(clean.Args) > 0 {
if ident, ok := clean.Args[0].(*ast.Ident); ok {
r.cleanedVar[ident.Obj.Decl] = n
// ident.Obj may be nil if the referenced declaration is in another file. It also may be incorrect.
// if it is nil, do not follow it.
if ident.Obj != nil {
r.cleanedVar[ident.Obj.Decl] = n
}
}
}
}