Files
Ravi Sastry Kadali 1341aeadb4 fix(G705): eliminate false positive for non-HTTP io.Writer (#1550)
* fix(G705): eliminate false positive for non-HTTP io.Writer

Adds ArgTypeGuards map[int]string to taint.Sink. The XSS analyzer now
requires arg[0] of fmt.Fprint* to implement net/http.ResponseWriter.
Writing exec pipe output to os.Stdout no longer triggers G705.

Fixes: #1548

* improve code coverage
2026-02-27 08:01:14 +01:00

116 lines
4.2 KiB
Go

// (c) Copyright gosec's authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package analyzers
import (
"golang.org/x/tools/go/analysis"
"github.com/securego/gosec/v2/taint"
)
// XSS returns a configuration for detecting Cross-Site Scripting vulnerabilities.
func XSS() taint.Config {
return taint.Config{
Sources: []taint.Source{
// Type sources: tainted when received as parameters
{Package: "net/http", Name: "Request", Pointer: true},
{Package: "net/url", Name: "Values"},
// Function sources
{Package: "os", Name: "Args", IsFunc: true},
// I/O sources
{Package: "bufio", Name: "Reader", Pointer: true},
{Package: "bufio", Name: "Scanner", Pointer: true},
},
Sinks: []taint.Sink{
// Direct write on the response writer itself — receiver already scopes it.
{Package: "net/http", Receiver: "ResponseWriter", Method: "Write"},
// fmt print family: arg[0] is the io.Writer target; args[1..n] are the
// format string and variadic data (all checked for taint).
// Guard: only treat as a sink when arg[0] implements net/http.ResponseWriter.
// Writing to os.Stdout, os.Stderr, bytes.Buffer, exec pipes, etc. is NOT flagged.
{
Package: "fmt",
Method: "Fprintf",
CheckArgs: []int{1, 2, 3, 4, 5, 6, 7, 8, 9, 10},
ArgTypeGuards: map[int]string{0: "net/http.ResponseWriter"},
},
{
Package: "fmt",
Method: "Fprint",
CheckArgs: []int{1, 2, 3, 4, 5, 6, 7, 8, 9, 10},
ArgTypeGuards: map[int]string{0: "net/http.ResponseWriter"},
},
{
Package: "fmt",
Method: "Fprintln",
CheckArgs: []int{1, 2, 3, 4, 5, 6, 7, 8, 9, 10},
ArgTypeGuards: map[int]string{0: "net/http.ResponseWriter"},
},
// io.WriteString: same rationale — only a sink when the writer is HTTP.
{
Package: "io",
Method: "WriteString",
CheckArgs: []int{1},
ArgTypeGuards: map[int]string{0: "net/http.ResponseWriter"},
},
// Template functions that unsafely inject untrusted content
{Package: "html/template", Method: "HTML"},
{Package: "html/template", Method: "HTMLAttr"},
{Package: "html/template", Method: "JS"},
{Package: "html/template", Method: "CSS"},
},
Sanitizers: []taint.Sanitizer{
// html.EscapeString escapes HTML special characters
{Package: "html", Method: "EscapeString"},
// html/template auto-escaping functions
{Package: "html/template", Method: "HTMLEscapeString"},
{Package: "html/template", Method: "JSEscapeString"},
{Package: "html/template", Method: "URLQueryEscaper"},
// url.QueryEscape for URL parameter escaping
{Package: "net/url", Method: "QueryEscape"},
{Package: "net/url", Method: "PathEscape"},
// JSON encoding produces structurally safe output that cannot
// contain unescaped HTML tags or script injections. The output
// is served as application/json, not text/html.
{Package: "encoding/json", Method: "Marshal"},
{Package: "encoding/json", Method: "MarshalIndent"},
// Integer/float conversions produce numeric strings that cannot
// contain XSS payloads.
{Package: "strconv", Method: "Atoi"},
{Package: "strconv", Method: "Itoa"},
{Package: "strconv", Method: "ParseInt"},
{Package: "strconv", Method: "ParseUint"},
{Package: "strconv", Method: "ParseFloat"},
{Package: "strconv", Method: "FormatInt"},
{Package: "strconv", Method: "FormatUint"},
{Package: "strconv", Method: "FormatFloat"},
},
}
}
// newXSSAnalyzer creates an analyzer for detecting XSS vulnerabilities
// via taint analysis (G705)
func newXSSAnalyzer(id string, description string) *analysis.Analyzer {
config := XSS()
rule := XSSRule
rule.ID = id
rule.Description = description
return taint.NewGosecAnalyzer(&rule, &config)
}