Files
gosec/testutils/g704_samples.go
T
Ravi Sastry Kadali baf0dcfbec fix(taint): gate *http.Request auto-taint on entry-point detection (#1630)
* fix(taint): gate *http.Request auto-taint on entry-point detection (#1629)

isParameterTainted unconditionally tainted any *http.Request parameter by
type, even when the function had known callers passing constant-URL requests.

Check the CHA call graph first: only auto-taint when the function has no
in-edges (true external entry point). When callers exist, fall through to
the existing caller-verification loop instead.
Fixes #1629

* Address Barry AI Security Analysis

* improve code coverage

* fix lint

* taint mechanism, framework agnostic

* address lint warning
2026-04-08 11:31:24 +02:00

180 lines
3.3 KiB
Go

package testutils
import "github.com/securego/gosec/v2"
// SampleCodeG704 - SSRF via taint analysis
var SampleCodeG704 = []CodeSample{
{[]string{`
package main
import (
"net/http"
)
func handler(r *http.Request) {
url := r.URL.Query().Get("url")
http.Get(url)
}
`}, 1, gosec.NewConfig()},
{[]string{`
package main
import (
"net/http"
"os"
)
func fetchFromEnv() {
target := os.Getenv("TARGET_URL")
http.Post(target, "text/plain", nil)
}
`}, 1, gosec.NewConfig()},
{[]string{`
package main
import (
"net/http"
)
func safeRequest() {
// Safe - hardcoded URL
http.Get("https://api.example.com/data")
}
`}, 0, gosec.NewConfig()},
{[]string{`
package main
import (
"context"
"net/http"
"time"
)
func GetPublicIP() (string, error) {
ctx, cancel := context.WithTimeout(context.Background(), time.Second*10)
defer cancel()
req, err := http.NewRequestWithContext(ctx, http.MethodGet, "https://am.i.mullvad.net/ip", nil)
if err != nil {
return "", err
}
resp, err := http.DefaultClient.Do(req)
if err != nil {
return "", err
}
defer resp.Body.Close()
return "", nil
}
`}, 0, gosec.NewConfig()},
// Constant URL string must NOT trigger G704.
{[]string{`
package main
import (
"context"
"net/http"
)
const url = "https://go.dev/"
func main() {
ctx := context.Background()
req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, http.NoBody)
if err != nil {
panic(err)
}
_, err = new(http.Client).Do(req)
if err != nil {
panic(err)
}
}
`}, 0, gosec.NewConfig()},
// Sanity check: variable URL from request still fires.
{[]string{`
package main
import (
"net/http"
)
func handler(r *http.Request) {
target := r.URL.Query().Get("url")
http.Get(target) //nolint:errcheck
}
`}, 1, gosec.NewConfig()},
// Issue #1629: NamedClient wrapper delegates to http.Client.Do.
// Request built with constant URL — must NOT trigger G704.
{[]string{`
package main
import (
"context"
"fmt"
"net/http"
)
type HTTPDoer interface {
Do(req *http.Request) (*http.Response, error)
}
type NamedClient struct {
HTTPClient *http.Client
}
func (c *NamedClient) Do(req *http.Request) (*http.Response, error) {
req.Header.Set("User-Agent", "test-agent")
return c.HTTPClient.Do(req)
}
func doImport(httpDoer HTTPDoer) error {
ctx := context.Background()
req, err := http.NewRequestWithContext(ctx, http.MethodPost, "/import", http.NoBody)
if err != nil {
return fmt.Errorf("creating import POST: %w", err)
}
resp, err := httpDoer.Do(req)
if err != nil {
return fmt.Errorf("performing import POST: %w", err)
}
defer resp.Body.Close()
return nil
}
`}, 0, gosec.NewConfig()},
// Issue #1629 counterpart: URL from os.Getenv through wrapper MUST still fire.
{[]string{`
package main
import (
"context"
"net/http"
"os"
)
type HTTPDoer interface {
Do(req *http.Request) (*http.Response, error)
}
type NamedClient struct {
HTTPClient *http.Client
}
func (c *NamedClient) Do(req *http.Request) (*http.Response, error) {
return c.HTTPClient.Do(req)
}
func doImport(httpDoer HTTPDoer) error {
target := os.Getenv("IMPORT_URL")
ctx := context.Background()
req, err := http.NewRequestWithContext(ctx, http.MethodPost, target, http.NoBody)
if err != nil {
return err
}
resp, err := httpDoer.Do(req)
if err != nil {
return err
}
defer resp.Body.Close()
return nil
}
`}, 1, gosec.NewConfig()},
}