go/ko-build
1
0
Fork 0
mirror of https://github.com/ko-build/ko.git synced 2025-11-06 09:19:12 +02:00
Code Issues Releases Activity

Print platform variant when building go binary (#248)

Browse Source
This commit is contained in:
jonjohnsonjr
2020-11-20 09:15:04 -08:00
committed by GitHub
parent bd1ec540fa
commit 1c704388dc
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/build/gobuild.go
View File

@@ -231,6 +231,14 @@ func getGoarm(platform v1.Platform) (string, error) {
return "", nil
}
// TODO(jonjohnsonjr): Upstream something like this.
func platformToString(p v1.Platform) string {
if p.Variant != "" {
return fmt.Sprintf("%s/%s/%s", p.OS, p.Architecture, p.Variant)
}
return fmt.Sprintf("%s/%s", p.OS, p.Architecture)
}
func build(ctx context.Context, ip string, platform v1.Platform, disableOptimizations bool) (string, error) {
tmpDir, err := ioutil.TempDir("", "ko")
if err != nil {
@@ -272,7 +280,7 @@ func build(ctx context.Context, ip string, platform v1.Platform, disableOptimiza
cmd.Stderr = &output
cmd.Stdout = &output
log.Printf("Building %s for %s/%s", ip, platform.OS, platform.Architecture)
log.Printf("Building %s for %s", ip, platformToString(platform))
if err := cmd.Run(); err != nil {
os.RemoveAll(tmpDir)
log.Printf("Unexpected error running \"go build\": %v\n%v", err, output.String())