go/ko-build
1
0
Fork 0
mirror of https://github.com/ko-build/ko.git synced 2026-06-18 20:14:08 +02:00
Code Issues Releases Activity

Reorder parsing KO_DOCKER_REPO to get proper credentials (#117)

Browse Source 
Fixes #93

With this change we support also pointing to default registry (without prefix).
Eg. KO_DOCKER_REPO=myuser
This commit is contained in:
cezkuj
2019-12-18 09:47:56 -08:00
committed by jonjohnsonjr
parent d24b60a88f
commit 1fcfe62a96
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/publish/options.go
+4 -4
View File
@@ -48,16 +48,16 @@ func WithAuthFromKeychain(keys authn.Keychain) Option {
// means that docker.io/mattmoor actually gets interpreted as
// docker.io/library/mattmoor, which gets tricky when we start
// appending things to it in the publisher.
reg, err := name.NewRegistry(i.base)
repo, err := name.NewRepository(i.base)
if err != nil {
// Workaround for localhost:5000 as KO_DOCKER_REPO.
repo, err := name.NewRepository(i.base)
reg, err := name.NewRegistry(i.base)
if err != nil {
return err
}
reg = repo.Registry
repo = name.Repository{Registry: reg}
}
auth, err := keys.Resolve(reg)
auth, err := keys.Resolve(repo.Registry)
if err != nil {
return err
}