mirror of
https://github.com/ko-build/ko.git
synced 2025-02-07 19:30:23 +02:00
When resolving files, we would just log.Fatal if we encountered an error. This seems to be racy and causes ko to exit with a 0 error code when it shouldn't. To fix this, we synchronize the builder goroutines with the kubectl go routine and exit with an error if either of them failed. This fix also happened to fix a goroutine leak. If the kubectl goroutine failed, we never properly cancelled the builds, which would happily conitnue compiling packages and consuming resources.