1
0
mirror of https://github.com/ko-build/ko.git synced 2025-02-07 19:30:23 +02:00
jonjohnsonjr cfd680de28
Deterministically fail ko {apply, create} (#133)
When resolving files, we would just log.Fatal if we encountered an
error. This seems to be racy and causes ko to exit with a 0 error code
when it shouldn't. To fix this, we synchronize the builder goroutines
with the kubectl go routine and exit with an error if either of them
failed.

This fix also happened to fix a goroutine leak. If the kubectl goroutine
failed, we never properly cancelled the builds, which would happily
conitnue compiling packages and consuming resources.
2020-02-11 10:44:25 -08:00
..
2019-09-20 09:39:18 -07:00
2019-07-08 17:04:58 -07:00
2020-02-06 13:51:22 -08:00
2019-11-09 09:23:09 -08:00
2019-11-09 09:23:09 -08:00
2019-12-06 10:52:34 -08:00