mirror of
https://github.com/ko-build/ko.git
synced 2025-04-07 21:38:44 +02:00
ff61ea330c
This change more or less completely changes how `ko://` is handled internally to `ko`, but the user-facing changes should only be net-positive. `ko://` was previously stripped at the highest level, and the build logic was unaware, which had some undesirable diagnostic/functional implications that are collectively addressed in this change. With this change, the `ko://` prefix is preserved and passed to the build logic, which internally parses a new `reference` type (this was useful to have Go's type checker find all of the places that needed fixing). The main functional differences are: 1. If a reference is prefixed with `ko://` we will now fail fast in `IsSupportedReference` regardless of whether `--strict` is passed. 2. If a reference is prefixed with `ko://` it will bypass the prefix check, which allows the use of `ko://github.com/another/repo` that references a vendored binary package. For `2.` the absence of the module prefix causes the filtering logic Jon introduced to avoid the reference. This was critical for efficiency when `ko://` isn't around because we feed every string in the yaml through it, but when the user has explicitly decorated things it's the perfect thing to be sensitive to. Fixes: https://github.com/google/ko/issues/146 Fixes: https://github.com/google/ko/issues/152
52 lines
1.4 KiB
Go
52 lines
1.4 KiB
Go
// Copyright 2020 Google LLC All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package build
|
|
|
|
import "testing"
|
|
|
|
func TestStrictReference(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
input string
|
|
strict bool
|
|
path string
|
|
}{{
|
|
name: "loose",
|
|
input: "github.com/foo/bar",
|
|
strict: false,
|
|
path: "github.com/foo/bar",
|
|
}, {
|
|
name: "strict",
|
|
input: "ko://github.com/foo/bar",
|
|
strict: true,
|
|
path: "github.com/foo/bar",
|
|
}}
|
|
|
|
for _, test := range tests {
|
|
t.Run(test.name, func(t *testing.T) {
|
|
ref := newRef(test.input)
|
|
if got, want := ref.IsStrict(), test.strict; got != want {
|
|
t.Errorf("got: %v, want: %v", got, want)
|
|
}
|
|
if got, want := ref.Path(), test.path; got != want {
|
|
t.Errorf("got: %v, want: %v", got, want)
|
|
}
|
|
if got, want := ref.String(), test.input; got != want {
|
|
t.Errorf("got: %v, want: %v", got, want)
|
|
}
|
|
})
|
|
}
|
|
}
|