go/kratos
1
0
Fork 0
mirror of https://github.com/go-kratos/kratos.git synced 2025-03-29 21:57:16 +02:00
Code Issues Releases Activity

fix bug of host.Extract ()

Browse Source
This commit is contained in:
letian 2021-09-15 18:02:26 +08:00 committed by GitHub
parent 24ec23f0e4
commit 2ce8f22fac
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 1 deletions
internal/host
host.gohost_test.go

2
internal/host/host.go

@ -36,7 +36,7 @@ func Port(lis net.Listener) (int, bool) {
// Extract returns a private addr and port. // Extract returns a private addr and port.
func Extract(hostPort string, lis net.Listener) (string, error) { func Extract(hostPort string, lis net.Listener) (string, error) {
addr, port, err := net.SplitHostPort(hostPort) addr, port, err := net.SplitHostPort(hostPort)
if err != nil { if err != nil && lis == nil {
return "", err return "", err
} }
if lis != nil { if lis != nil {

7
internal/host/host_test.go

@ -76,6 +76,13 @@ func TestExtract(t *testing.T) {
} }
}) })
} }
lis, err := net.Listen("tcp", ":12345")
assert.NoError(t, err)
res, err := Extract("", lis)
assert.NoError(t, err)
expect, err := Extract(lis.Addr().String(), nil)
assert.NoError(t, err)
assert.Equal(t, expect, res)
} }
func TestExtract2(t *testing.T) { func TestExtract2(t *testing.T) {