go/kratos
1
0
Fork 0
mirror of https://github.com/go-kratos/kratos.git synced 2025-03-17 21:07:54 +02:00
Code Issues Releases Activity

fix http.Server closed

Browse Source
This commit is contained in:
chenzhihui 2021-02-17 22:54:41 +08:00
parent c089611e5d
commit 4c67fa1235
3 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
transport/http/server.go
View File

@ -2,6 +2,7 @@ package http
import (
"context"
"errors"
"fmt"
"net"
"net/http"
@ -152,7 +153,10 @@ func (s *Server) Start() error {
}
s.lis = lis
s.log.Infof("[HTTP] server listening on: %s", lis.Addr().String())
return s.Serve(lis)
if err := s.Serve(lis); !errors.Is(err, http.ErrServerClosed) {
return err
}
return nil
}
// Stop stop the HTTP server.

3
transport/http/server_test.go
View File

@ -3,7 +3,6 @@ package http
import (
"context"
"encoding/json"
"errors"
"fmt"
"net/http"
"testing"
@ -38,7 +37,7 @@ func TestServer(t *testing.T) {
testClient(t, srv)
})
if err := srv.Start(); !errors.Is(err, http.ErrServerClosed) {
if err := srv.Start(); err != nil {
t.Fatal(err)
}
}

3
transport/http/service_test.go
View File

@ -4,7 +4,6 @@ import (
"bytes"
"context"
"encoding/json"
"errors"
"fmt"
"net/http"
"testing"
@ -61,7 +60,7 @@ func TestService(t *testing.T) {
testServiceClient(t, srv)
})
if err := srv.Start(); !errors.Is(err, http.ErrServerClosed) {
if err := srv.Start(); err != nil {
t.Fatal(err)
}
}