From 80378ca10dc7560c711ccd7a8b22ea0320f0965c Mon Sep 17 00:00:00 2001 From: Xudong Cai Date: Sun, 15 Aug 2021 17:02:59 +0800 Subject: [PATCH] fix: if not kratos context then panic will result (#1338) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix: if not kratos context panic 当ctx不是kratos的context,则app.Name()会导致panic --- middleware/tracing/metadata.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/middleware/tracing/metadata.go b/middleware/tracing/metadata.go index ec5acb20b..7e8cbe951 100644 --- a/middleware/tracing/metadata.go +++ b/middleware/tracing/metadata.go @@ -17,8 +17,10 @@ var _ propagation.TextMapPropagator = Metadata{} // Inject sets metadata key-values from ctx into the carrier. func (b Metadata) Inject(ctx context.Context, carrier propagation.TextMapCarrier) { - app, _ := kratos.FromContext(ctx) - carrier.Set(serviceHeader, app.Name()) + app, ok := kratos.FromContext(ctx) + if ok { + carrier.Set(serviceHeader, app.Name()) + } } // Extract returns a copy of parent with the metadata from the carrier added.