From 0a63f701e5bc5d3d78b34dcb71f7343e520ae385 Mon Sep 17 00:00:00 2001 From: Denis Palashevskii <20725046+Renerick@users.noreply.github.com> Date: Tue, 8 Jun 2021 11:01:19 +0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Mark Kopenga --- pkg/commands/pull_request.go | 8 +++----- pkg/i18n/dutch.go | 4 ++-- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/pkg/commands/pull_request.go b/pkg/commands/pull_request.go index 9a29ae17a..40cabd0c7 100644 --- a/pkg/commands/pull_request.go +++ b/pkg/commands/pull_request.go @@ -155,11 +155,9 @@ func (pr *PullRequest) getPullRequestURL(from *models.Branch, to *models.Branch) } repoInfo := getRepoInfoFromURL(repoURL) - var toBranchName string - if to == nil { - toBranchName = "" - } else { - toBranchName = to.Name + toBranchName := "" + if to != nil { + toBranchName = to.Name } pullRequestURL := gitService.PullRequestURL(repoInfo.Owner, repoInfo.Repository, from.Name, toBranchName) diff --git a/pkg/i18n/dutch.go b/pkg/i18n/dutch.go index e52a2ead5..fca78466e 100644 --- a/pkg/i18n/dutch.go +++ b/pkg/i18n/dutch.go @@ -396,7 +396,7 @@ func dutchTranslationSet() TranslationSet { LcInitSubmodule: "initialiseer submodule", LcViewBulkSubmoduleOptions: "bekijk bulk submodule opties", LcViewStashFiles: "bekijk bestanden van stash entry", - CreatePullRequestOptions: "Maak opties voor pull-aanvragen", - LcCreatePullRequestOptions: "maak opties voor pull-aanvragen", + CreatePullRequestOptions: "Creëer pull request opties", + LcCreatePullRequestOptions: "creëer pull request opties", } }