mirror of
https://github.com/jesseduffield/lazygit.git
synced 2025-06-17 00:18:05 +02:00
Changes as per review
This commit is contained in:
committed by
Jesse Duffield
parent
257e222f8d
commit
0c6bdac2f7
@ -462,6 +462,9 @@ func (gui *Gui) handleCommitPick() error {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (gui *Gui) handleCommitRevert() error {
|
func (gui *Gui) handleCommitRevert() error {
|
||||||
|
if ok, err := gui.validateNotInFilterMode(); err != nil || !ok {
|
||||||
|
return err
|
||||||
|
}
|
||||||
commit := gui.getSelectedLocalCommit()
|
commit := gui.getSelectedLocalCommit()
|
||||||
return gui.ask(askOpts{
|
return gui.ask(askOpts{
|
||||||
title: gui.Tr.Actions.RevertCommit,
|
title: gui.Tr.Actions.RevertCommit,
|
||||||
@ -471,9 +474,6 @@ func (gui *Gui) handleCommitRevert() error {
|
|||||||
"selectedCommit": commit.ShortSha(),
|
"selectedCommit": commit.ShortSha(),
|
||||||
}),
|
}),
|
||||||
handleConfirm: func() error {
|
handleConfirm: func() error {
|
||||||
if ok, err := gui.validateNotInFilterMode(); err != nil || !ok {
|
|
||||||
return err
|
|
||||||
}
|
|
||||||
|
|
||||||
if commit.IsMerge() {
|
if commit.IsMerge() {
|
||||||
return gui.createRevertMergeCommitMenu(commit)
|
return gui.createRevertMergeCommitMenu(commit)
|
||||||
@ -496,17 +496,31 @@ func (gui *Gui) createRevertMergeCommitMenu(commit *models.Commit) error {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
return gui.surfaceError(err)
|
return gui.surfaceError(err)
|
||||||
}
|
}
|
||||||
|
parentShortSha := utils.SafeTruncate(parentSha, 8)
|
||||||
menuItems[i] = &menuItem{
|
menuItems[i] = &menuItem{
|
||||||
displayString: fmt.Sprintf("%s: %s", utils.SafeTruncate(parentSha, 8), message),
|
displayString: fmt.Sprintf("%s: %s", parentShortSha, message),
|
||||||
onPress: func() error {
|
onPress: func() error {
|
||||||
parentNumber := i + 1
|
parentNumber := i + 1
|
||||||
gui.logAction(gui.Tr.Actions.RevertCommit)
|
gui.logAction(gui.Tr.Actions.RevertCommit)
|
||||||
|
gui.ask(askOpts{
|
||||||
|
title: gui.Tr.SelectParentCommitForMerge,
|
||||||
|
prompt: utils.ResolvePlaceholderString(
|
||||||
|
"Are you sure you want use {{.selectedParentCommit}} as parent commit?",
|
||||||
|
map[string]string{
|
||||||
|
"selectedParentCommit": parentShortSha,
|
||||||
|
}),
|
||||||
|
handleConfirm: func() error {
|
||||||
if err := gui.Git.Commit.RevertMerge(commit.Sha, parentNumber); err != nil {
|
if err := gui.Git.Commit.RevertMerge(commit.Sha, parentNumber); err != nil {
|
||||||
return gui.surfaceError(err)
|
return gui.surfaceError(err)
|
||||||
}
|
}
|
||||||
return gui.afterRevertCommit()
|
return gui.afterRevertCommit()
|
||||||
},
|
},
|
||||||
|
handleClose: func() error {
|
||||||
|
return gui.pushContext(gui.State.Contexts.Menu)
|
||||||
|
},
|
||||||
|
})
|
||||||
|
return nil
|
||||||
|
},
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user