From 1494a3863da457eb023178fdcc0512d59e73acbe Mon Sep 17 00:00:00 2001 From: Jesse Duffield Date: Tue, 25 Aug 2020 20:44:36 +1000 Subject: [PATCH] Remove tab keybinding for cycling tab This keybinding has been more pain than it's worth. Having a tab keybinding to cycle tabs implies that you can shift+tab and when you shift+tab the application exits because termbox, our dependency, doesn't know how to interpret the escape sequence (so it takes it for an actual ESC key which will exit lazygit at the top level). If people get mad at me they can set nextBlock-alt to and they'll have the functionality back :) --- pkg/gui/keybindings.go | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/gui/keybindings.go b/pkg/gui/keybindings.go index 19b576c06..833381207 100644 --- a/pkg/gui/keybindings.go +++ b/pkg/gui/keybindings.go @@ -1529,7 +1529,6 @@ func (gui *Gui) GetInitialKeybindings() []*Binding { for _, viewName := range []string{"status", "branches", "files", "commits", "commitFiles", "stash", "menu"} { bindings = append(bindings, []*Binding{ - {ViewName: viewName, Key: gui.getKey("universal.togglePanel"), Modifier: gocui.ModNone, Handler: gui.wrappedHandler(gui.nextSideWindow)}, {ViewName: viewName, Key: gui.getKey("universal.prevBlock"), Modifier: gocui.ModNone, Handler: gui.wrappedHandler(gui.previousSideWindow)}, {ViewName: viewName, Key: gui.getKey("universal.nextBlock"), Modifier: gocui.ModNone, Handler: gui.wrappedHandler(gui.nextSideWindow)}, {ViewName: viewName, Key: gui.getKey("universal.prevBlock-alt"), Modifier: gocui.ModNone, Handler: gui.wrappedHandler(gui.previousSideWindow)},