go/lazygit
1
0
Fork 0
mirror of https://github.com/jesseduffield/lazygit.git synced 2025-08-06 22:33:07 +02:00
Code Issues Releases Activity

Cleanup: use nil for empty slice

Browse Source
This commit is contained in:
Stefan Haller
2025-07-27 18:38:53 +02:00
parent 26f2c0203b
commit 15f8ad31e0
2 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/commands/git_commands/commit_loader.go
View File

@ -214,7 +214,7 @@ func (self *CommitLoader) extractCommitFromLine(hashPool *utils.StringPool, line
} }
message := split[7] message := split[7]
tags := []string{} var tags []string
if extraInfo != "" { if extraInfo != "" {
extraInfoFields := strings.Split(extraInfo, ",") extraInfoFields := strings.Split(extraInfo, ",")

18
pkg/commands/git_commands/commit_loader_test.go
View File

@ -86,7 +86,7 @@ func TestGetCommits(t *testing.T) {
Name: "better typing for rebase mode", Name: "better typing for rebase mode",
Status: models.StatusUnpushed, Status: models.StatusUnpushed,
Action: models.ActionNone, Action: models.ActionNone,
Tags: []string{}, Tags: nil,
ExtraInfo: "(HEAD -> better-tests)", ExtraInfo: "(HEAD -> better-tests)",
AuthorName: "Jesse Duffield", AuthorName: "Jesse Duffield",
AuthorEmail: "jessedduffield@gmail.com", AuthorEmail: "jessedduffield@gmail.com",
@ -100,7 +100,7 @@ func TestGetCommits(t *testing.T) {
Name: "fix logging", Name: "fix logging",
Status: models.StatusPushed, Status: models.StatusPushed,
Action: models.ActionNone, Action: models.ActionNone,
Tags: []string{}, Tags: nil,
ExtraInfo: "(origin/better-tests)", ExtraInfo: "(origin/better-tests)",
AuthorName: "Jesse Duffield", AuthorName: "Jesse Duffield",
AuthorEmail: "jessedduffield@gmail.com", AuthorEmail: "jessedduffield@gmail.com",
@ -128,7 +128,7 @@ func TestGetCommits(t *testing.T) {
Name: "WIP", Name: "WIP",
Status: models.StatusPushed, Status: models.StatusPushed,
Action: models.ActionNone, Action: models.ActionNone,
Tags: []string{}, Tags: nil,
ExtraInfo: "", ExtraInfo: "",
AuthorName: "Jesse Duffield", AuthorName: "Jesse Duffield",
AuthorEmail: "jessedduffield@gmail.com", AuthorEmail: "jessedduffield@gmail.com",
@ -142,7 +142,7 @@ func TestGetCommits(t *testing.T) {
Name: "WIP", Name: "WIP",
Status: models.StatusPushed, Status: models.StatusPushed,
Action: models.ActionNone, Action: models.ActionNone,
Tags: []string{}, Tags: nil,
ExtraInfo: "", ExtraInfo: "",
AuthorName: "Jesse Duffield", AuthorName: "Jesse Duffield",
AuthorEmail: "jessedduffield@gmail.com", AuthorEmail: "jessedduffield@gmail.com",
@ -156,7 +156,7 @@ func TestGetCommits(t *testing.T) {
Name: "WIP", Name: "WIP",
Status: models.StatusMerged, Status: models.StatusMerged,
Action: models.ActionNone, Action: models.ActionNone,
Tags: []string{}, Tags: nil,
ExtraInfo: "", ExtraInfo: "",
AuthorName: "Jesse Duffield", AuthorName: "Jesse Duffield",
AuthorEmail: "jessedduffield@gmail.com", AuthorEmail: "jessedduffield@gmail.com",
@ -170,7 +170,7 @@ func TestGetCommits(t *testing.T) {
Name: "WIP", Name: "WIP",
Status: models.StatusMerged, Status: models.StatusMerged,
Action: models.ActionNone, Action: models.ActionNone,
Tags: []string{}, Tags: nil,
ExtraInfo: "", ExtraInfo: "",
AuthorName: "Jesse Duffield", AuthorName: "Jesse Duffield",
AuthorEmail: "jessedduffield@gmail.com", AuthorEmail: "jessedduffield@gmail.com",
@ -184,7 +184,7 @@ func TestGetCommits(t *testing.T) {
Name: "refactoring the config struct", Name: "refactoring the config struct",
Status: models.StatusMerged, Status: models.StatusMerged,
Action: models.ActionNone, Action: models.ActionNone,
Tags: []string{}, Tags: nil,
ExtraInfo: "", ExtraInfo: "",
AuthorName: "Jesse Duffield", AuthorName: "Jesse Duffield",
AuthorEmail: "jessedduffield@gmail.com", AuthorEmail: "jessedduffield@gmail.com",
@ -220,7 +220,7 @@ func TestGetCommits(t *testing.T) {
Name: "better typing for rebase mode", Name: "better typing for rebase mode",
Status: models.StatusUnpushed, Status: models.StatusUnpushed,
Action: models.ActionNone, Action: models.ActionNone,
Tags: []string{}, Tags: nil,
ExtraInfo: "(HEAD -> better-tests)", ExtraInfo: "(HEAD -> better-tests)",
AuthorName: "Jesse Duffield", AuthorName: "Jesse Duffield",
AuthorEmail: "jessedduffield@gmail.com", AuthorEmail: "jessedduffield@gmail.com",
@ -258,7 +258,7 @@ func TestGetCommits(t *testing.T) {
Name: "better typing for rebase mode", Name: "better typing for rebase mode",
Status: models.StatusUnpushed, Status: models.StatusUnpushed,
Action: models.ActionNone, Action: models.ActionNone,
Tags: []string{}, Tags: nil,
ExtraInfo: "(HEAD -> better-tests)", ExtraInfo: "(HEAD -> better-tests)",
AuthorName: "Jesse Duffield", AuthorName: "Jesse Duffield",
AuthorEmail: "jessedduffield@gmail.com", AuthorEmail: "jessedduffield@gmail.com",