go/lazygit
1
0
Fork 0
mirror of https://github.com/jesseduffield/lazygit.git synced 2025-07-15 01:34:26 +02:00
Code Issues Releases Activity

Return an error if document is not a dictionary

Browse Source
This commit is contained in:
Stefan Haller
2023-06-08 08:45:07 +02:00
parent 90084d115e
commit 221433522d
2 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/utils/yaml_utils/yaml_utils.go
View File

@ -1,6 +1,7 @@
package yaml_utils package yaml_utils
import ( import (
"errors"
"fmt" "fmt"
"gopkg.in/yaml.v3" "gopkg.in/yaml.v3"
@ -24,6 +25,10 @@ func UpdateYamlValue(yamlBytes []byte, path []string, value string) ([]byte, err
body := node.Content[0] body := node.Content[0]
if body.Kind != yaml.MappingNode {
return yamlBytes, errors.New("yaml document is not a dictionary")
}
updateYamlNode(body, path, value) updateYamlNode(body, path, value)
// Convert the updated YAML node back to YAML bytes. // Convert the updated YAML node back to YAML bytes.

10
pkg/utils/yaml_utils/yaml_utils_test.go
View File

@ -56,6 +56,16 @@ func TestUpdateYamlValue(t *testing.T) {
expectedOut: "foo:\n bar: qux\n", expectedOut: "foo:\n bar: qux\n",
expectedErr: "", expectedErr: "",
}, },
// Error cases
{
name: "existing document is not a dictionary",
in: "42\n",
path: []string{"foo"},
value: "bar",
expectedOut: "42\n",
expectedErr: "yaml document is not a dictionary",
},
} }
for _, test := range tests { for _, test := range tests {