go/lazygit
1
0
Fork 0
mirror of https://github.com/jesseduffield/lazygit.git synced 2025-06-17 00:18:05 +02:00
Code Issues Releases Activity

Fix windows tests

Browse Source 
Now that the tests run again, it turns out that they actually fail, so fix them.
This commit is contained in:
Stefan Haller
2023-03-29 14:46:46 +02:00
parent 8d3cce4a49
commit 24de156592
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
pkg/commands/oscommands/os_windows_test.go
View File

@ -6,6 +6,7 @@ package oscommands
import ( import (
"testing" "testing"
"github.com/cli/safeexec"
"github.com/go-errors/errors" "github.com/go-errors/errors"
"github.com/stretchr/testify/assert" "github.com/stretchr/testify/assert"
) )
@ -19,11 +20,13 @@ func TestOSCommandOpenFileWindows(t *testing.T) {
test func(error) test func(error)
} }
fullCmdPath, _ := safeexec.LookPath("cmd")
scenarios := []scenario{ scenarios := []scenario{
{ {
filename: "test", filename: "test",
runner: NewFakeRunner(t). runner: NewFakeRunner(t).
ExpectArgs([]string{"cmd", "/c", "start", "", "test"}, "", errors.New("error")), ExpectArgs([]string{fullCmdPath, "/c", "start", "", "test"}, "", errors.New("error")),
test: func(err error) { test: func(err error) {
assert.Error(t, err) assert.Error(t, err)
}, },
@ -31,7 +34,7 @@ func TestOSCommandOpenFileWindows(t *testing.T) {
{ {
filename: "test", filename: "test",
runner: NewFakeRunner(t). runner: NewFakeRunner(t).
ExpectArgs([]string{"cmd", "/c", "start", "", "test"}, "", nil), ExpectArgs([]string{fullCmdPath, "/c", "start", "", "test"}, "", nil),
test: func(err error) { test: func(err error) {
assert.NoError(t, err) assert.NoError(t, err)
}, },
@ -39,7 +42,7 @@ func TestOSCommandOpenFileWindows(t *testing.T) {
{ {
filename: "filename with spaces", filename: "filename with spaces",
runner: NewFakeRunner(t). runner: NewFakeRunner(t).
ExpectArgs([]string{"cmd", "/c", "start", "", "filename with spaces"}, "", nil), ExpectArgs([]string{fullCmdPath, "/c", "start", "", "filename with spaces"}, "", nil),
test: func(err error) { test: func(err error) {
assert.NoError(t, err) assert.NoError(t, err)
}, },
@ -47,7 +50,7 @@ func TestOSCommandOpenFileWindows(t *testing.T) {
{ {
filename: "let's_test_with_single_quote", filename: "let's_test_with_single_quote",
runner: NewFakeRunner(t). runner: NewFakeRunner(t).
ExpectArgs([]string{"cmd", "/c", "start", "", "let's_test_with_single_quote"}, "", nil), ExpectArgs([]string{fullCmdPath, "/c", "start", "", "let's_test_with_single_quote"}, "", nil),
test: func(err error) { test: func(err error) {
assert.NoError(t, err) assert.NoError(t, err)
}, },
@ -55,7 +58,7 @@ func TestOSCommandOpenFileWindows(t *testing.T) {
{ {
filename: "$USER.txt", filename: "$USER.txt",
runner: NewFakeRunner(t). runner: NewFakeRunner(t).
ExpectArgs([]string{"cmd", "/c", "start", "", "$USER.txt"}, "", nil), ExpectArgs([]string{fullCmdPath, "/c", "start", "", "$USER.txt"}, "", nil),
test: func(err error) { test: func(err error) {
assert.NoError(t, err) assert.NoError(t, err)
}, },