From 26e58b8def2b981143fe902e05c9a4bb23a95dd1 Mon Sep 17 00:00:00 2001 From: Chris McDonnell Date: Wed, 14 May 2025 21:56:31 -0400 Subject: [PATCH] Remove the call to OnCommitSuccess from tag creation This is no change in behavior because OnCommitSuccess only clears the message when the commit message panel was opened with preserveMessage=true, which it isn't in the case of creating a tag. And this is in fact the desired behavior, because we don't want creating a tag to interfere with preserving commit messages in any way. --- pkg/gui/controllers/helpers/tags_helper.go | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/gui/controllers/helpers/tags_helper.go b/pkg/gui/controllers/helpers/tags_helper.go index dccc26e00..022b7969b 100644 --- a/pkg/gui/controllers/helpers/tags_helper.go +++ b/pkg/gui/controllers/helpers/tags_helper.go @@ -34,7 +34,6 @@ func (self *TagsHelper) OpenCreateTagPrompt(ref string, onCreate func()) error { } return self.gpg.WithGpgHandling(command, git_commands.TagGpgSign, self.c.Tr.CreatingTag, func() error { - self.commitsHelper.OnCommitSuccess() return nil }, []types.RefreshableView{types.COMMITS, types.TAGS}) }