1
0
mirror of https://github.com/jesseduffield/lazygit.git synced 2025-04-23 12:18:51 +02:00

feat: let interactive rebase prepend commands to the default todo file

This commit is contained in:
AzraelSec 2023-03-29 00:49:19 +02:00 committed by Jesse Duffield
parent e18b4a4cc3
commit 368f9c8cb3
3 changed files with 36 additions and 13 deletions

View File

@ -29,6 +29,11 @@ const (
const ( const (
DaemonKindEnvKey string = "LAZYGIT_DAEMON_KIND" DaemonKindEnvKey string = "LAZYGIT_DAEMON_KIND"
RebaseTODOEnvKey string = "LAZYGIT_REBASE_TODO" RebaseTODOEnvKey string = "LAZYGIT_REBASE_TODO"
// The `PrependLinesEnvKey` env variable is set to `true` to tell our daemon
// to prepend the content of `RebaseTODOEnvKey` to the default `git-rebase-todo`
// file instead of using it as a replacement.
PrependLinesEnvKey string = "LAZYGIT_PREPEND_LINES"
) )
type Daemon interface { type Daemon interface {
@ -74,12 +79,25 @@ type rebaseDaemon struct {
func (self *rebaseDaemon) Run() error { func (self *rebaseDaemon) Run() error {
self.c.Log.Info("Lazygit invoked as interactive rebase demon") self.c.Log.Info("Lazygit invoked as interactive rebase demon")
self.c.Log.Info("args: ", os.Args) self.c.Log.Info("args: ", os.Args)
filePath := os.Args[1]
if strings.HasSuffix(os.Args[1], "git-rebase-todo") { if strings.HasSuffix(filePath, "git-rebase-todo") {
if err := os.WriteFile(os.Args[1], []byte(os.Getenv(RebaseTODOEnvKey)), 0o644); err != nil { todoEnvKey := os.Getenv(RebaseTODOEnvKey)
var todoContent []byte
if v := os.Getenv(PrependLinesEnvKey); v != "" {
existingContent, err := os.ReadFile(filePath)
if err != nil {
return err return err
} }
} else if strings.HasSuffix(os.Args[1], filepath.Join(gitDir(), "COMMIT_EDITMSG")) { // TODO: test
todoContent = append([]byte(todoEnvKey), existingContent...)
} else {
todoContent = []byte(todoEnvKey)
}
return os.WriteFile(filePath, todoContent, 0o644)
} else if strings.HasSuffix(filePath, filepath.Join(gitDir(), "COMMIT_EDITMSG")) { // TODO: test
// if we are rebasing and squashing, we'll see a COMMIT_EDITMSG // if we are rebasing and squashing, we'll see a COMMIT_EDITMSG
// but in this case we don't need to edit it, so we'll just return // but in this case we don't need to edit it, so we'll just return
} else { } else {

View File

@ -111,7 +111,7 @@ func (self *PatchCommands) MovePatchToSelectedCommit(commits []*models.Commit, s
} }
}) })
err := self.rebase.PrepareInteractiveRebaseCommand(commits[baseIndex].Sha, todoLines, true).Run() err := self.rebase.PrepareInteractiveRebaseCommand(commits[baseIndex].Sha, todoLines, true, false).Run()
if err != nil { if err != nil {
return err return err
} }

View File

@ -60,7 +60,7 @@ func (self *RebaseCommands) RewordCommitInEditor(commits []*models.Commit, index
return nil, err return nil, err
} }
return self.PrepareInteractiveRebaseCommand(sha, todo, false), nil return self.PrepareInteractiveRebaseCommand(sha, todo, false, false), nil
} }
func (self *RebaseCommands) ResetCommitAuthor(commits []*models.Commit, index int) error { func (self *RebaseCommands) ResetCommitAuthor(commits []*models.Commit, index int) error {
@ -104,7 +104,7 @@ func (self *RebaseCommands) MoveCommitDown(commits []*models.Commit, index int)
baseShaOrRoot := getBaseShaOrRoot(commits, index+2) baseShaOrRoot := getBaseShaOrRoot(commits, index+2)
return self.PrepareInteractiveRebaseCommand(baseShaOrRoot, todoLines, true).Run() return self.PrepareInteractiveRebaseCommand(baseShaOrRoot, todoLines, true, false).Run()
} }
func (self *RebaseCommands) InteractiveRebase(commits []*models.Commit, index int, action string) error { func (self *RebaseCommands) InteractiveRebase(commits []*models.Commit, index int, action string) error {
@ -113,7 +113,7 @@ func (self *RebaseCommands) InteractiveRebase(commits []*models.Commit, index in
return err return err
} }
return self.PrepareInteractiveRebaseCommand(sha, todo, true).Run() return self.PrepareInteractiveRebaseCommand(sha, todo, true, false).Run()
} }
func (self *RebaseCommands) InteractiveRebaseBreakAfter(commits []*models.Commit, index int) error { func (self *RebaseCommands) InteractiveRebaseBreakAfter(commits []*models.Commit, index int) error {
@ -123,15 +123,19 @@ func (self *RebaseCommands) InteractiveRebaseBreakAfter(commits []*models.Commit
} }
todo = append(todo, TodoLine{Action: "break", Commit: nil}) todo = append(todo, TodoLine{Action: "break", Commit: nil})
return self.PrepareInteractiveRebaseCommand(sha, todo, true).Run() return self.PrepareInteractiveRebaseCommand(sha, todo, true, false).Run()
} }
// PrepareInteractiveRebaseCommand returns the cmd for an interactive rebase // PrepareInteractiveRebaseCommand returns the cmd for an interactive rebase
// we tell git to run lazygit to edit the todo list, and we pass the client // we tell git to run lazygit to edit the todo list, and we pass the client
// lazygit a todo string to write to the todo file // lazygit a todo string to write to the todo file
func (self *RebaseCommands) PrepareInteractiveRebaseCommand(baseShaOrRoot string, todoLines []TodoLine, overrideEditor bool) oscommands.ICmdObj { func (self *RebaseCommands) PrepareInteractiveRebaseCommand(baseShaOrRoot string, todoLines []TodoLine, overrideEditor bool, prepend bool) oscommands.ICmdObj {
todo := self.buildTodo(todoLines) todo := self.buildTodo(todoLines)
ex := oscommands.GetLazygitPath() ex := oscommands.GetLazygitPath()
prependLines := ""
if prepend {
prependLines = "TRUE"
}
debug := "FALSE" debug := "FALSE"
if self.Debug { if self.Debug {
@ -153,6 +157,7 @@ func (self *RebaseCommands) PrepareInteractiveRebaseCommand(baseShaOrRoot string
cmdObj.AddEnvVars( cmdObj.AddEnvVars(
daemon.DaemonKindEnvKey+"="+string(daemon.InteractiveRebase), daemon.DaemonKindEnvKey+"="+string(daemon.InteractiveRebase),
daemon.RebaseTODOEnvKey+"="+todo, daemon.RebaseTODOEnvKey+"="+todo,
daemon.PrependLinesEnvKey+"="+prependLines,
"DEBUG="+debug, "DEBUG="+debug,
"LANG=en_US.UTF-8", // Force using EN as language "LANG=en_US.UTF-8", // Force using EN as language
"LC_ALL=en_US.UTF-8", // Force using EN as language "LC_ALL=en_US.UTF-8", // Force using EN as language
@ -273,12 +278,12 @@ func (self *RebaseCommands) BeginInteractiveRebaseForCommit(commits []*models.Co
return err return err
} }
return self.PrepareInteractiveRebaseCommand(sha, todo, true).Run() return self.PrepareInteractiveRebaseCommand(sha, todo, true, false).Run()
} }
// RebaseBranch interactive rebases onto a branch // RebaseBranch interactive rebases onto a branch
func (self *RebaseCommands) RebaseBranch(branchName string) error { func (self *RebaseCommands) RebaseBranch(branchName string) error {
return self.PrepareInteractiveRebaseCommand(branchName, nil, false).Run() return self.PrepareInteractiveRebaseCommand(branchName, nil, false, false).Run()
} }
func (self *RebaseCommands) GenericMergeOrRebaseActionCmdObj(commandType string, command string) oscommands.ICmdObj { func (self *RebaseCommands) GenericMergeOrRebaseActionCmdObj(commandType string, command string) oscommands.ICmdObj {
@ -363,7 +368,7 @@ func (self *RebaseCommands) DiscardOldFileChanges(commits []*models.Commit, comm
func (self *RebaseCommands) CherryPickCommits(commits []*models.Commit) error { func (self *RebaseCommands) CherryPickCommits(commits []*models.Commit) error {
todoLines := self.BuildTodoLinesSingleAction(commits, "pick") todoLines := self.BuildTodoLinesSingleAction(commits, "pick")
return self.PrepareInteractiveRebaseCommand("HEAD", todoLines, false).Run() return self.PrepareInteractiveRebaseCommand("HEAD", todoLines, false, false).Run()
} }
func (self *RebaseCommands) buildTodo(todoLines []TodoLine) string { func (self *RebaseCommands) buildTodo(todoLines []TodoLine) string {