From 527a1596f3afa8a43659a518147bf10107e7ee47 Mon Sep 17 00:00:00 2001 From: Stefan Haller Date: Wed, 16 Aug 2023 17:49:08 +0200 Subject: [PATCH] Add tests for scroll-off margin of zero --- pkg/gui/controllers/scroll_off_margin_test.go | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/pkg/gui/controllers/scroll_off_margin_test.go b/pkg/gui/controllers/scroll_off_margin_test.go index 099da299f..4059aaa48 100644 --- a/pkg/gui/controllers/scroll_off_margin_test.go +++ b/pkg/gui/controllers/scroll_off_margin_test.go @@ -52,6 +52,15 @@ func Test_calculateLinesToScrollUp(t *testing.T) { lineIdxAfter: 12, expectedLinesToScroll: 1, }, + { + name: "scroll-off margin is zero - scroll by 1 at end of view", + viewPortStart: 10, + viewPortHeight: 10, + scrollOffMargin: 0, + lineIdxBefore: 10, + lineIdxAfter: 9, + expectedLinesToScroll: 1, + }, { name: "before inside scroll-off margin - scroll by more than 1", viewPortStart: 10, @@ -134,6 +143,15 @@ func Test_calculateLinesToScrollDown(t *testing.T) { lineIdxAfter: 17, expectedLinesToScroll: 1, }, + { + name: "scroll-off margin is zero - scroll by 1 at end of view", + viewPortStart: 10, + viewPortHeight: 10, + scrollOffMargin: 0, + lineIdxBefore: 19, + lineIdxAfter: 20, + expectedLinesToScroll: 1, + }, { name: "before inside scroll-off margin - scroll by more than 1", viewPortStart: 10,