go/lazygit
1
0
Fork 0
mirror of https://github.com/jesseduffield/lazygit.git synced 2025-06-17 00:18:05 +02:00
Code Issues Releases Activity

Cleanup: use the upstream local variable consistently

Browse Source 
We need to move it closer to the beginning of the method to use it everywhere.
This commit is contained in:
Stefan Haller
2025-01-04 15:19:33 +01:00
parent 009062534e
commit 53b1e12110
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
pkg/gui/controllers/branches_controller.go
View File

@ -194,6 +194,10 @@ func (self *BranchesController) GetOnRenderToMain() func() {
} }
func (self *BranchesController) viewUpstreamOptions(selectedBranch *models.Branch) error { func (self *BranchesController) viewUpstreamOptions(selectedBranch *models.Branch) error {
upstream := lo.Ternary(selectedBranch.RemoteBranchStoredLocally(),
selectedBranch.ShortUpstreamRefName(),
self.c.Tr.UpstreamGenericName)
viewDivergenceItem := &types.MenuItem{ viewDivergenceItem := &types.MenuItem{
LabelColumns: []string{self.c.Tr.ViewDivergenceFromUpstream}, LabelColumns: []string{self.c.Tr.ViewDivergenceFromUpstream},
OnPress: func() error { OnPress: func() error {
@ -204,7 +208,7 @@ func (self *BranchesController) viewUpstreamOptions(selectedBranch *models.Branc
return self.c.Helpers().SubCommits.ViewSubCommits(helpers.ViewSubCommitsOpts{ return self.c.Helpers().SubCommits.ViewSubCommits(helpers.ViewSubCommitsOpts{
Ref: branch, Ref: branch,
TitleRef: fmt.Sprintf("%s <-> %s", branch.RefName(), branch.ShortUpstreamRefName()), TitleRef: fmt.Sprintf("%s <-> %s", branch.RefName(), upstream),
RefToShowDivergenceFrom: branch.FullUpstreamRefName(), RefToShowDivergenceFrom: branch.FullUpstreamRefName(),
Context: self.context(), Context: self.context(),
ShowBranchHeads: false, ShowBranchHeads: false,
@ -293,9 +297,6 @@ func (self *BranchesController) viewUpstreamOptions(selectedBranch *models.Branc
Key: 's', Key: 's',
} }
upstream := lo.Ternary(selectedBranch.RemoteBranchStoredLocally(),
selectedBranch.ShortUpstreamRefName(),
self.c.Tr.UpstreamGenericName)
upstreamResetOptions := utils.ResolvePlaceholderString( upstreamResetOptions := utils.ResolvePlaceholderString(
self.c.Tr.ViewUpstreamResetOptions, self.c.Tr.ViewUpstreamResetOptions,
map[string]string{"upstream": upstream}, map[string]string{"upstream": upstream},
@ -332,7 +333,7 @@ func (self *BranchesController) viewUpstreamOptions(selectedBranch *models.Branc
LabelColumns: []string{upstreamRebaseOptions}, LabelColumns: []string{upstreamRebaseOptions},
OpensMenu: true, OpensMenu: true,
OnPress: func() error { OnPress: func() error {
if err := self.c.Helpers().MergeAndRebase.RebaseOntoRef(selectedBranch.ShortUpstreamRefName()); err != nil { if err := self.c.Helpers().MergeAndRebase.RebaseOntoRef(upstream); err != nil {
return err return err
} }
return nil return nil