From 58a83b08627e1488ff99cf80fd3ab2d28af90104 Mon Sep 17 00:00:00 2001 From: Stefan Haller Date: Fri, 13 Oct 2023 18:00:59 +0200 Subject: [PATCH] Remove special code to rerender views on screen mode change The previous commit handles this case too. --- pkg/gui/controllers/screen_mode_actions.go | 26 +--------------------- 1 file changed, 1 insertion(+), 25 deletions(-) diff --git a/pkg/gui/controllers/screen_mode_actions.go b/pkg/gui/controllers/screen_mode_actions.go index d31154636..1db27f2e2 100644 --- a/pkg/gui/controllers/screen_mode_actions.go +++ b/pkg/gui/controllers/screen_mode_actions.go @@ -1,7 +1,6 @@ package controllers import ( - "github.com/jesseduffield/gocui" "github.com/jesseduffield/lazygit/pkg/gui/types" ) @@ -17,7 +16,7 @@ func (self *ScreenModeActions) Next() error { ), ) - return self.rerenderViewsWithScreenModeDependentContent() + return nil } func (self *ScreenModeActions) Prev() error { @@ -28,32 +27,9 @@ func (self *ScreenModeActions) Prev() error { ), ) - return self.rerenderViewsWithScreenModeDependentContent() -} - -// these views need to be re-rendered when the screen mode changes. The commits view, -// for example, will show authorship information in half and full screen mode. -func (self *ScreenModeActions) rerenderViewsWithScreenModeDependentContent() error { - // for now we re-render all list views. - for _, context := range self.c.Context().AllList() { - if err := self.rerenderView(context.GetView()); err != nil { - return err - } - } - return nil } -func (self *ScreenModeActions) rerenderView(view *gocui.View) error { - context, ok := self.c.Helpers().View.ContextForView(view.Name()) - if !ok { - self.c.Log.Errorf("no context found for view %s", view.Name()) - return nil - } - - return context.HandleRender() -} - func nextIntInCycle(sl []types.WindowMaximisation, current types.WindowMaximisation) types.WindowMaximisation { for i, val := range sl { if val == current {