From 5d6d8942862428afb72bc45b562af10ceac6e0a3 Mon Sep 17 00:00:00 2001 From: Jesse Duffield Date: Sat, 8 Jan 2022 15:46:29 +1100 Subject: [PATCH] fix test --- .../git_config/cached_git_config_test.go | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/pkg/commands/git_config/cached_git_config_test.go b/pkg/commands/git_config/cached_git_config_test.go index f03535a6e..1e58b2bf6 100644 --- a/pkg/commands/git_config/cached_git_config_test.go +++ b/pkg/commands/git_config/cached_git_config_test.go @@ -1,6 +1,8 @@ package git_config import ( + "os/exec" + "strings" "testing" "github.com/jesseduffield/lazygit/pkg/utils" @@ -52,8 +54,9 @@ func TestGetBool(t *testing.T) { t.Run(s.testName, func(t *testing.T) { fake := NewFakeGitConfig(s.mockResponses) real := NewCachedGitConfig( - func(key string) (string, error) { - return fake.Get(key), nil + func(cmd *exec.Cmd) (string, error) { + assert.Equal(t, "git config --get --null commit.gpgsign", strings.Join(cmd.Args, " ")) + return fake.Get("commit.gpgsign"), nil }, utils.NewDummyLog(), ) @@ -88,8 +91,9 @@ func TestGet(t *testing.T) { t.Run(s.testName, func(t *testing.T) { fake := NewFakeGitConfig(s.mockResponses) real := NewCachedGitConfig( - func(key string) (string, error) { - return fake.Get(key), nil + func(cmd *exec.Cmd) (string, error) { + assert.Equal(t, "git config --get --null commit.gpgsign", strings.Join(cmd.Args, " ")) + return fake.Get("commit.gpgsign"), nil }, utils.NewDummyLog(), ) @@ -101,9 +105,9 @@ func TestGet(t *testing.T) { // verifying that the cache is used count := 0 real := NewCachedGitConfig( - func(key string) (string, error) { + func(cmd *exec.Cmd) (string, error) { count++ - assert.Equal(t, "commit.gpgsign", key) + assert.Equal(t, "git config --get --null commit.gpgsign", strings.Join(cmd.Args, " ")) return "blah", nil }, utils.NewDummyLog(),