some more standardisation for diffing

pkg/commands/branch.go

@@ -12,3 +12,7 @@ type Branch struct {
 	UpstreamName string
 	Head         bool
 }
+
+func (b *Branch) RefName() string {
+	return b.Name
+}

pkg/commands/commit.go

@@ -24,3 +24,7 @@ func (c *Commit) ShortSha() string {
 func (c *Commit) NameWithSha() string {
 	return fmt.Sprintf("%s %s", c.Sha[:7], c.Name)
 }
+
+func (c *Commit) RefName() string {
+	return c.Sha
+}

pkg/commands/remote.go

@@ -6,3 +6,7 @@ type Remote struct {
 	Urls     []string
 	Branches []*RemoteBranch
 }
+
+func (r *Remote) RefName() string {
+	return r.Name
+}

pkg/commands/remote_branch.go

@@ -9,3 +9,7 @@ type RemoteBranch struct {
 func (r *RemoteBranch) FullName() string {
 	return r.RemoteName + "/" + r.Name
 }
+
+func (r *RemoteBranch) RefName() string {
+	return r.FullName()
+}

pkg/commands/tag.go

@@ -4,3 +4,7 @@ package commands
 type Tag struct {
 	Name string
 }
+
+func (t *Tag) RefName() string {
+	return t.Name
+}

pkg/gui/diffing.go

@@ -5,7 +5,6 @@ import (
 	"strings"
 
 	"github.com/jesseduffield/gocui"
-	"github.com/jesseduffield/lazygit/pkg/commands"
 )
 
 func (gui *Gui) inDiffMode() bool {
@@ -42,62 +41,55 @@ func (gui *Gui) renderDiff() error {
 // which becomes an option when you bring up the diff menu, but when you're just
 // flicking through branches it will be using the local branch name.
 func (gui *Gui) currentDiffTerminals() []string {
-	currentView := gui.g.CurrentView()
+	switch gui.currentContextKey() {
-	if currentView == nil {
-		return nil
-	}
-	names := []string{}
-	switch currentView.Name() {
 	case "files":
 		// not supporting files for now
-
+	case "commit-files":
-	case "commitFiles":
 		// not supporting commit files for now
-
+	case "branch-commits":
-	case "commits":
+		item := gui.getSelectedCommit()
-		var commit *commands.Commit
+		if item != nil {
-		switch gui.getCommitsView().Context {
+			return []string{item.RefName()}
-		case "reflog-commits":
-			commit = gui.getSelectedReflogCommit()
-		case "branch-commits":
-			commit = gui.getSelectedCommit()
 		}
-		if commit != nil {
+	case "reflog-commits":
-			names = append(names, commit.Sha)
+		item := gui.getSelectedReflogCommit()
+		if item != nil {
+			return []string{item.RefName()}
 		}
 	case "stash":
-		entry := gui.getSelectedStashEntry()
+		item := gui.getSelectedStashEntry()
-		if entry != nil {
+		if item != nil {
-			names = append(names, entry.RefName())
+			return []string{item.RefName()}
 		}
-	case "branches":
+
-		switch gui.getBranchesView().Context {
+	case "local-branches":
-		case "local-branches":
+		branch := gui.getSelectedBranch()
-			branch := gui.getSelectedBranch()
+		if branch != nil {
-			if branch != nil {
+			names := []string{branch.RefName()}
-				names = append(names, branch.Name)
+			if branch.UpstreamName != "" {
-				if branch.UpstreamName != "" {
+				names = append(names, branch.UpstreamName)
-					names = append(names, branch.UpstreamName)
-				}
-			}
-		case "remotes":
-			remote := gui.getSelectedRemote()
-			if remote != nil {
-				names = append(names, remote.Name)
-			}
-		case "remote-branches":
-			remoteBranch := gui.getSelectedRemoteBranch()
-			if remoteBranch != nil {
-				names = append(names, remoteBranch.FullName())
-			}
-		case "tags":
-			tag := gui.getSelectedTag()
-			if tag != nil {
-				names = append(names, tag.Name)
 			}
+			return names
+		}
+		return nil
+	case "remotes":
+		item := gui.getSelectedRemote()
+		if item != nil {
+			return []string{item.RefName()}
+		}
+	case "remote-branches":
+		item := gui.getSelectedRemoteBranch()
+		if item != nil {
+			return []string{item.RefName()}
+		}
+	case "tags":
+		item := gui.getSelectedTag()
+		if item != nil {
+			return []string{item.RefName()}
 		}
 	}
-	return names
+
+	return nil
 }
 
 func (gui *Gui) currentDiffTerminal() string {

pkg/gui/list_context.go

@@ -326,7 +326,7 @@ func (gui *Gui) stashListContext() *ListContext {
 func (gui *Gui) commitFilesListContext() *ListContext {
 	return &ListContext{
 		ViewName:              "commitFiles",
-		ContextKey:            "commitFiles",
+		ContextKey:            "commit-files",
 		GetItemsLength:        func() int { return len(gui.State.CommitFiles) },
 		GetSelectedLineIdxPtr: func() *int { return &gui.State.Panels.CommitFiles.SelectedLine },
 		OnFocus:               gui.handleCommitFileSelect,