mirror of
				https://github.com/jesseduffield/lazygit.git
				synced 2025-10-30 23:57:43 +02:00 
			
		
		
		
	Fix crash when trying to filter the list of remotes
This seems to be a left-over from an earlier iteration of the code. Removing it fixes the crash.
This commit is contained in:
		| @@ -9,7 +9,6 @@ import ( | |||||||
| type RemotesContext struct { | type RemotesContext struct { | ||||||
| 	*FilteredListViewModel[*models.Remote] | 	*FilteredListViewModel[*models.Remote] | ||||||
| 	*ListContextTrait | 	*ListContextTrait | ||||||
| 	*SearchHistory |  | ||||||
| } | } | ||||||
|  |  | ||||||
| var ( | var ( | ||||||
|   | |||||||
							
								
								
									
										42
									
								
								pkg/integration/tests/filter_and_search/filter_remotes.go
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										42
									
								
								pkg/integration/tests/filter_and_search/filter_remotes.go
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,42 @@ | |||||||
|  | package filter_and_search | ||||||
|  |  | ||||||
|  | import ( | ||||||
|  | 	"github.com/jesseduffield/lazygit/pkg/config" | ||||||
|  | 	. "github.com/jesseduffield/lazygit/pkg/integration/components" | ||||||
|  | ) | ||||||
|  |  | ||||||
|  | var FilterRemotes = NewIntegrationTest(NewIntegrationTestArgs{ | ||||||
|  | 	Description:  "Filtering remotes", | ||||||
|  | 	ExtraCmdArgs: []string{}, | ||||||
|  | 	Skip:         false, | ||||||
|  | 	SetupConfig:  func(config *config.AppConfig) {}, | ||||||
|  | 	SetupRepo: func(shell *Shell) { | ||||||
|  | 		shell.EmptyCommit("commit-one") | ||||||
|  | 		shell.CloneIntoRemote("remote1") | ||||||
|  | 		shell.CloneIntoRemote("remote2") | ||||||
|  | 		shell.CloneIntoRemote("remote3") | ||||||
|  | 	}, | ||||||
|  | 	Run: func(t *TestDriver, keys config.KeybindingConfig) { | ||||||
|  | 		t.Views().Remotes(). | ||||||
|  | 			Focus(). | ||||||
|  | 			Lines( | ||||||
|  | 				Contains("remote1").IsSelected(), | ||||||
|  | 				Contains("remote2"), | ||||||
|  | 				Contains("remote3"), | ||||||
|  | 			). | ||||||
|  | 			FilterOrSearch("2"). | ||||||
|  | 			Lines( | ||||||
|  | 				Contains("remote2").IsSelected(), | ||||||
|  | 			). | ||||||
|  | 			// cancel the filter | ||||||
|  | 			PressEscape(). | ||||||
|  | 			Tap(func() { | ||||||
|  | 				t.Views().Search().IsInvisible() | ||||||
|  | 			}). | ||||||
|  | 			Lines( | ||||||
|  | 				Contains("remote1"), | ||||||
|  | 				Contains("remote2").IsSelected(), | ||||||
|  | 				Contains("remote3"), | ||||||
|  | 			) | ||||||
|  | 	}, | ||||||
|  | }) | ||||||
| @@ -131,6 +131,7 @@ var tests = []*components.IntegrationTest{ | |||||||
| 	filter_and_search.FilterMenu, | 	filter_and_search.FilterMenu, | ||||||
| 	filter_and_search.FilterMenuCancelFilterWithEscape, | 	filter_and_search.FilterMenuCancelFilterWithEscape, | ||||||
| 	filter_and_search.FilterRemoteBranches, | 	filter_and_search.FilterRemoteBranches, | ||||||
|  | 	filter_and_search.FilterRemotes, | ||||||
| 	filter_and_search.FilterSearchHistory, | 	filter_and_search.FilterSearchHistory, | ||||||
| 	filter_and_search.NestedFilter, | 	filter_and_search.NestedFilter, | ||||||
| 	filter_and_search.NestedFilterTransient, | 	filter_and_search.NestedFilterTransient, | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user