go/lazygit
1
0
Fork 0
mirror of https://github.com/jesseduffield/lazygit.git synced 2025-04-25 12:24:47 +02:00
Code Issues Releases Activity

better error handling for commands

Browse Source
This commit is contained in:
Jesse Duffield 2018-09-01 13:27:58 +10:00
parent 04d5a473d7
commit 865809e625
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/commands/os.go
View File

@ -90,6 +90,9 @@ func sanitisedCommandOutput(output []byte, err error) (string, error) {
if err != nil { if err != nil {
// errors like 'exit status 1' are not very useful so we'll create an error // errors like 'exit status 1' are not very useful so we'll create an error
// from the combined output // from the combined output
if outputString == "" {
return "", err
}
return outputString, errors.New(outputString) return outputString, errors.New(outputString)
} }
return outputString, nil return outputString, nil
@ -111,7 +114,7 @@ func (c *OSCommand) OpenFile(filename string) error {
} }
command := utils.ResolvePlaceholderString(commandTemplate, templateValues) command := utils.ResolvePlaceholderString(commandTemplate, templateValues)
err := c.RunCommand(command) _, err := c.RunCommandWithOutput(command)
return err return err
} }