Merge pull request #1944 from Ryooooooga/feature/fix-ambiguous-refname

pkg/commands/models/branch.go

@@ -18,6 +18,10 @@ type Branch struct {
 	UpstreamBranch string
 }
 
+func (b *Branch) FullRefName() string {
+	return "refs/heads/" + b.Name
+}
+
 func (b *Branch) RefName() string {
 	return b.Name
 }

pkg/commands/models/commit.go

@@ -29,6 +29,10 @@ func (c *Commit) ShortSha() string {
 	return utils.ShortSha(c.Sha)
 }
 
+func (c *Commit) FullRefName() string {
+	return c.Sha
+}
+
 func (c *Commit) RefName() string {
 	return c.Sha
 }

pkg/commands/models/remote_branch.go

@@ -10,6 +10,10 @@ func (r *RemoteBranch) FullName() string {
 	return r.RemoteName + "/" + r.Name
 }
 
+func (r *RemoteBranch) FullRefName() string {
+	return "refs/remotes/" + r.FullName()
+}
+
 func (r *RemoteBranch) RefName() string {
 	return r.FullName()
 }

pkg/commands/models/stash_entry.go

@@ -8,6 +8,10 @@ type StashEntry struct {
 	Name  string
 }
 
+func (s *StashEntry) FullRefName() string {
+	return s.RefName()
+}
+
 func (s *StashEntry) RefName() string {
 	return fmt.Sprintf("stash@{%d}", s.Index)
 }

pkg/commands/models/tag.go

@@ -5,6 +5,10 @@ type Tag struct {
 	Name string
 }
 
+func (t *Tag) FullRefName() string {
+	return "refs/tags/" + t.RefName()
+}
+
 func (t *Tag) RefName() string {
 	return t.Name
 }

pkg/gui/branches_panel.go

@@ -6,7 +6,7 @@ func (gui *Gui) branchesRenderToMain() error {
 	if branch == nil {
 		task = NewRenderStringTask(gui.c.Tr.NoBranchesThisRepo)
 	} else {
-		cmdObj := gui.git.Branch.GetGraphCmdObj(branch.Name)
+		cmdObj := gui.git.Branch.GetGraphCmdObj(branch.FullRefName())
 
 		task = NewRunPtyTask(cmdObj.GetCmd())
 	}

pkg/gui/controllers/switch_to_sub_commits_controller.go

@@ -62,7 +62,7 @@ func (self *SwitchToSubCommitsController) viewCommits() error {
 			Limit:                true,
 			FilterPath:           self.modes.Filtering.GetPath(),
 			IncludeRebaseCommits: false,
-			RefName:              ref.RefName(),
+			RefName:              ref.FullRefName(),
 		},
 	)
 	if err != nil {

pkg/gui/remote_branches_panel.go

@@ -6,7 +6,7 @@ func (gui *Gui) remoteBranchesRenderToMain() error {
 	if remoteBranch == nil {
 		task = NewRenderStringTask("No branches for this remote")
 	} else {
-		cmdObj := gui.git.Branch.GetGraphCmdObj(remoteBranch.FullName())
+		cmdObj := gui.git.Branch.GetGraphCmdObj(remoteBranch.FullRefName())
 		task = NewRunCommandTask(cmdObj.GetCmd())
 	}
 

pkg/gui/tags_panel.go

@@ -6,7 +6,7 @@ func (self *Gui) tagsRenderToMain() error {
 	if tag == nil {
 		task = NewRenderStringTask("No tags")
 	} else {
-		cmdObj := self.git.Branch.GetGraphCmdObj(tag.Name)
+		cmdObj := self.git.Branch.GetGraphCmdObj(tag.FullRefName())
 		task = NewRunCommandTask(cmdObj.GetCmd())
 	}
 

pkg/gui/types/ref.go

@@ -1,6 +1,7 @@
 package types
 
 type Ref interface {
+	FullRefName() string
 	RefName() string
 	ParentRefName() string
 	Description() string