From 641467bc797c9623a8c11ff727b3522da1dbf83a Mon Sep 17 00:00:00 2001
From: Stefan Haller <stefan@haller-berlin.de>
Date: Wed, 25 Feb 2026 18:52:00 +0100
Subject: [PATCH] Hide the "Fetching..." status of the auto-fetch when bottom
 line is not showing

If the bottom line is hidden (by setting gui.showBottomLine to false in the
config), don't show the "Fetching..." status because it changes the layout,
which should happen only in response to user actions.

However, keep the status for the first fetch after startup, and right after
switching repos, because in these cases it is useful to see when the fetch is
done.
---
 pkg/gui/background.go | 28 ++++++++++++++++------------
 1 file changed, 16 insertions(+), 12 deletions(-)

diff --git a/pkg/gui/background.go b/pkg/gui/background.go
index 73964838c..e1720cd63 100644
--- a/pkg/gui/background.go
+++ b/pkg/gui/background.go
@@ -52,7 +52,7 @@ func (self *BackgroundRoutineMgr) startBackgroundRoutines() {
 	}
 
 	if self.gui.Config.GetDebug() {
-		self.goEvery(time.Second*time.Duration(10), self.gui.stopChan, func() error {
+		self.goEvery(time.Second*time.Duration(10), self.gui.stopChan, func(_ bool) error {
 			formatBytes := func(b uint64) string {
 				const unit = 1000
 				if b < unit {
@@ -78,7 +78,7 @@ func (self *BackgroundRoutineMgr) startBackgroundRoutines() {
 func (self *BackgroundRoutineMgr) startBackgroundFetch() {
 	self.gui.waitForIntro.Wait()
 
-	fetch := func() error {
+	fetch := func(firstTimeOrRetriggered bool) error {
 		// Do this on the UI thread so that we don't have to deal with synchronization around the
 		// access of the repo state.
 		self.gui.onUIThread(func() error {
@@ -89,14 +89,18 @@ func (self *BackgroundRoutineMgr) startBackgroundFetch() {
 			return nil
 		})
 
-		return self.gui.helpers.AppStatus.WithWaitingStatusImpl(self.gui.Tr.FetchingStatus, func(gocui.Task) error {
-			return self.backgroundFetch()
-		}, nil)
+		if self.gui.UserConfig().Gui.ShowBottomLine || firstTimeOrRetriggered {
+			return self.gui.helpers.AppStatus.WithWaitingStatusImpl(self.gui.Tr.FetchingStatus, func(gocui.Task) error {
+				return self.backgroundFetch()
+			}, nil)
+		}
+
+		return self.backgroundFetch()
 	}
 
 	// We want an immediate fetch at startup, and since goEvery starts by
 	// waiting for the interval, we need to trigger one manually first
-	_ = fetch()
+	_ = fetch(true)
 
 	userConfig := self.gui.UserConfig()
 	self.triggerFetch = self.goEvery(userConfig.Refresher.FetchIntervalDuration(), self.gui.stopChan, fetch)
@@ -106,25 +110,25 @@ func (self *BackgroundRoutineMgr) startBackgroundFilesRefresh() {
 	self.gui.waitForIntro.Wait()
 
 	userConfig := self.gui.UserConfig()
-	self.goEvery(userConfig.Refresher.RefreshIntervalDuration(), self.gui.stopChan, func() error {
+	self.goEvery(userConfig.Refresher.RefreshIntervalDuration(), self.gui.stopChan, func(_ bool) error {
 		self.gui.c.Refresh(types.RefreshOptions{Scope: []types.RefreshableView{types.FILES}})
 		return nil
 	})
 }
 
 // returns a channel that can be used to trigger the callback immediately
-func (self *BackgroundRoutineMgr) goEvery(interval time.Duration, stop chan struct{}, function func() error) chan struct{} {
+func (self *BackgroundRoutineMgr) goEvery(interval time.Duration, stop chan struct{}, function func(bool) error) chan struct{} {
 	done := make(chan struct{})
 	retrigger := make(chan struct{})
 	go utils.Safe(func() {
 		ticker := time.NewTicker(interval)
 		defer ticker.Stop()
-		doit := func() {
+		doit := func(retriggered bool) {
 			if self.pauseBackgroundRefreshes {
 				return
 			}
 			self.gui.c.OnWorker(func(gocui.Task) error {
-				_ = function()
+				_ = function(retriggered)
 				done <- struct{}{}
 				return nil
 			})
@@ -136,10 +140,10 @@ func (self *BackgroundRoutineMgr) goEvery(interval time.Duration, stop chan stru
 		for {
 			select {
 			case <-ticker.C:
-				doit()
+				doit(false)
 			case <-retrigger:
 				ticker.Reset(interval)
-				doit()
+				doit(true)
 			case <-stop:
 				return
 			}