go/lazygit
1
0
Fork 0
mirror of https://github.com/jesseduffield/lazygit.git synced 2025-06-15 00:15:32 +02:00
Code Issues Releases Activity

Cleanup: don't mess with globals in tests without resetting them

Browse Source 
Changing globals in the init() function of a test file is a bad idea, as it
affects all other tests that run after it. Do it explicitly in each test
function that needs it, and take care of restoring the previous value
afterwards.
This commit is contained in:
Stefan Haller
2024-03-27 19:22:24 +01:00
parent 1cedfa463b
commit c59e6b6451
5 changed files with 32 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/gui/presentation/branches_test.go
View File

@ -5,12 +5,14 @@ import (
"testing"
"time"
"github.com/gookit/color"
"github.com/jesseduffield/lazygit/pkg/commands/models"
"github.com/jesseduffield/lazygit/pkg/gui/presentation/icons"
"github.com/jesseduffield/lazygit/pkg/gui/types"
"github.com/jesseduffield/lazygit/pkg/utils"
"github.com/samber/lo"
"github.com/stretchr/testify/assert"
"github.com/xo/terminfo"
)
func Test_getBranchDisplayStrings(t *testing.T) {
@ -223,6 +225,9 @@ func Test_getBranchDisplayStrings(t *testing.T) {
},
}
oldColorLevel := color.ForceSetColorLevel(terminfo.ColorLevelNone)
defer color.ForceSetColorLevel(oldColorLevel)
c := utils.NewDummyCommon()
for i, s := range scenarios {