Enable revive linter, and fix a bunch of warnings

I took the set of enabled checks from revive's recommended configuration [1],
and removed some that I didn't like. There might be other useful checks in
revive that we might want to enable, but this is a nice improvement already.

The bulk of the changes here are removing unnecessary else statements after
returns, but there are a few others too.

[1] https://github.com/mgechev/revive?tab=readme-ov-file#recommended-configuration

pkg/utils/formatting.go

@@ -44,9 +44,8 @@ func WithPadding(str string, padding int, alignment Alignment) string {
 	space := strings.Repeat(" ", padding-width)
 	if alignment == AlignLeft {
 		return str + space
-	} else {
-		return space + str
 	}
+	return space + str
 }
 
 // defaults to left-aligning each column. If you want to set the alignment of
@@ -187,9 +186,8 @@ func TruncateWithEllipsis(str string, limit int) string {
 func SafeTruncate(str string, limit int) string {
 	if len(str) > limit {
 		return str[0:limit]
-	} else {
-		return str
 	}
+	return str
 }
 
 const COMMIT_HASH_SHORT_SIZE = 8

pkg/utils/once_writer_test.go

@@ -9,7 +9,7 @@ func TestOnceWriter(t *testing.T) {
 	innerWriter := bytes.NewBuffer(nil)
 	counter := 0
 	onceWriter := NewOnceWriter(innerWriter, func() {
-		counter += 1
+		counter++
 	})
 	_, _ = onceWriter.Write([]byte("hello"))
 	_, _ = onceWriter.Write([]byte("hello"))

pkg/utils/utils.go

@@ -45,9 +45,8 @@ func ModuloWithWrap(n, max int) int {
 		return n % max
 	} else if n < 0 {
 		return max + n
-	} else {
-		return n
 	}
+	return n
 }
 
 func FindStringSubmatch(str string, regexpStr string) (bool, []string) {

pkg/utils/yaml_utils/yaml_utils_test.go

@@ -224,12 +224,10 @@ func TestTransformNode(t *testing.T) {
 			} else if node.ShortTag() == "!!str" {
 				// We have already transformed it,
 				return nil
-			} else {
-				return fmt.Errorf("Node was of bad type")
 			}
-		} else {
-			return fmt.Errorf("Node was not a scalar")
+			return fmt.Errorf("Node was of bad type")
 		}
+		return fmt.Errorf("Node was not a scalar")
 	}
 
 	tests := []struct {