1
0
mirror of https://github.com/jesseduffield/lazygit.git synced 2025-07-11 01:20:48 +02:00

Enable revive linter, and fix a bunch of warnings

I took the set of enabled checks from revive's recommended configuration [1],
and removed some that I didn't like. There might be other useful checks in
revive that we might want to enable, but this is a nice improvement already.

The bulk of the changes here are removing unnecessary else statements after
returns, but there are a few others too.

[1] https://github.com/mgechev/revive?tab=readme-ov-file#recommended-configuration
This commit is contained in:
Stefan Haller
2025-06-30 19:13:12 +02:00
parent 7aa426fa71
commit ca05a2ccea
47 changed files with 152 additions and 170 deletions

View File

@ -44,9 +44,8 @@ func WithPadding(str string, padding int, alignment Alignment) string {
space := strings.Repeat(" ", padding-width)
if alignment == AlignLeft {
return str + space
} else {
return space + str
}
return space + str
}
// defaults to left-aligning each column. If you want to set the alignment of
@ -187,9 +186,8 @@ func TruncateWithEllipsis(str string, limit int) string {
func SafeTruncate(str string, limit int) string {
if len(str) > limit {
return str[0:limit]
} else {
return str
}
return str
}
const COMMIT_HASH_SHORT_SIZE = 8