go/lazygit
1
0
Fork 0
mirror of https://github.com/jesseduffield/lazygit.git synced 2025-06-17 00:18:05 +02:00
Code Issues Releases Activity

introduce platform specific defaults

Browse Source
This commit is contained in:
Jesse Duffield
2018-09-01 14:33:01 +10:00
parent ad880e2d56
commit d31520261f
8 changed files with 53 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
pkg/commands/os_test.go
View File

@ -76,48 +76,6 @@ func TestOSCommandRunCommand(t *testing.T) {
}
}
func TestOSCommandGetOpenCommand(t *testing.T) {
// two scenarios to test. One with a config set, the other with the platform default
type scenario struct {
before func(*OSCommand)
test func(string)
}
scenarios := []scenario{
{
func(OSCmd *OSCommand) {},
func(command string) {
assert.Equal(t, command, "open {{filename}}")
},
},
{
func(OSCmd *OSCommand) {
OSCmd.Config.GetUserConfig().Set("os.openCommand", "test {{filename}}")
},
func(command string) {
assert.Equal(t, command, "test {{filename}}")
},
},
{
func(OSCmd *OSCommand) {
OSCmd.Platform = &Platform{
openCommand: "platform specific open {{filename}}",
}
},
func(command string) {
assert.Equal(t, command, "platform specific open {{filename}}")
},
},
}
for _, s := range scenarios {
OSCmd := newDummyOSCommand()
s.before(OSCmd)
s.test(OSCmd.getOpenCommand())
}
}
func TestOSCommandOpenFile(t *testing.T) {
type scenario struct {
filename string
@ -138,8 +96,19 @@ func TestOSCommandOpenFile(t *testing.T) {
{
"test",
func(name string, arg ...string) *exec.Cmd {
assert.Equal(t, name, "bash")
assert.Equal(t, arg, []string{"-c", "open \"test\""})
assert.Equal(t, "open", name)
assert.Equal(t, []string{"test"}, arg)
return exec.Command("echo")
},
func(err error) {
assert.NoError(t, err)
},
},
{
"filename with spaces",
func(name string, arg ...string) *exec.Cmd {
assert.Equal(t, "open", name)
assert.Equal(t, []string{"filename with spaces"}, arg)
return exec.Command("echo")
},
func(err error) {
@ -151,6 +120,7 @@ func TestOSCommandOpenFile(t *testing.T) {
for _, s := range scenarios {
OSCmd := newDummyOSCommand()
OSCmd.command = s.command
OSCmd.Config.GetUserConfig().Set("os.openCommand", "open {{filename}}")
s.test(OSCmd.OpenFile(s.filename))
}