From 630c1720ac65388999ad809c14ec0fd7e021a2e8 Mon Sep 17 00:00:00 2001 From: jishudashu <979260390@qq.com> Date: Thu, 24 Jul 2025 11:30:00 +0800 Subject: [PATCH] refactor: use slices.Equal to simplify code Signed-off-by: jishudashu <979260390@qq.com> --- pkg/commands/git_commands/main_branches.go | 3 ++- pkg/utils/slice.go | 15 --------------- 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/pkg/commands/git_commands/main_branches.go b/pkg/commands/git_commands/main_branches.go index 19f809a4f..6bfc648db 100644 --- a/pkg/commands/git_commands/main_branches.go +++ b/pkg/commands/git_commands/main_branches.go @@ -1,6 +1,7 @@ package git_commands import ( + "slices" "strings" "sync" @@ -43,7 +44,7 @@ func (self *MainBranches) Get() []string { configuredMainBranches := self.c.UserConfig().Git.MainBranches - if self.existingMainBranches == nil || !utils.EqualSlices(self.previousMainBranches, configuredMainBranches) { + if self.existingMainBranches == nil || !slices.Equal(self.previousMainBranches, configuredMainBranches) { self.existingMainBranches = self.determineMainBranches(configuredMainBranches) self.previousMainBranches = configuredMainBranches } diff --git a/pkg/utils/slice.go b/pkg/utils/slice.go index c84217b77..0dc9e64e4 100644 --- a/pkg/utils/slice.go +++ b/pkg/utils/slice.go @@ -179,18 +179,3 @@ func Shift[T any](slice []T) (T, []T) { slice = slice[1:] return value, slice } - -// Compares two slices for equality -func EqualSlices[T comparable](slice1 []T, slice2 []T) bool { - if len(slice1) != len(slice2) { - return false - } - - for i := range slice1 { - if slice1[i] != slice2[i] { - return false - } - } - - return true -}