go/lazygit
1
0
Fork 0
mirror of https://github.com/jesseduffield/lazygit.git synced 2025-12-13 23:45:45 +02:00
Code Issues Releases Activity

Improve code quality

Browse Source 
- Make CommandMenuEntry private
- create candidates only once we really need it
- Use only 1 buffer
- Clearify CommandMenuEntry creation fields
This commit is contained in:
mjarkk
2021-08-06 21:50:53 +02:00
parent dcd3b7c058
commit ea136e4e77
2 changed files with 22 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/gui/gui_test.go
View File

@@ -88,7 +88,7 @@ func TestGuiGenerateMenuCandidates(t *testing.T) {
filter string
valueFormat string
labelFormat string
test func([]CommandMenuEntry, error)
test func([]commandMenuEntry, error)
}
scenarios := []scenario{
@@ -98,7 +98,7 @@ func TestGuiGenerateMenuCandidates(t *testing.T) {
"(?P<remote>[a-z_]+)/(?P<branch>.*)",
"{{ .branch }}",
"Remote: {{ .remote }}",
func(actualEntry []CommandMenuEntry, err error) {
func(actualEntry []commandMenuEntry, err error) {
assert.NoError(t, err)
assert.EqualValues(t, "pr-1", actualEntry[0].value)
assert.EqualValues(t, "Remote: upstream", actualEntry[0].label)
@@ -110,7 +110,7 @@ func TestGuiGenerateMenuCandidates(t *testing.T) {
"(?P<remote>[a-z]*)/(?P<branch>.*)",
"{{ .branch }}|{{ .remote }}",
"",
func(actualEntry []CommandMenuEntry, err error) {
func(actualEntry []commandMenuEntry, err error) {
assert.NoError(t, err)
assert.EqualValues(t, "pr-1|upstream", actualEntry[0].value)
assert.EqualValues(t, "pr-1|upstream", actualEntry[0].label)
@@ -122,7 +122,7 @@ func TestGuiGenerateMenuCandidates(t *testing.T) {
"(?P<remote>[a-z]*)/(?P<branch>.*)",
"{{ .group_2 }}|{{ .group_1 }}",
"Remote: {{ .group_1 }}",
func(actualEntry []CommandMenuEntry, err error) {
func(actualEntry []commandMenuEntry, err error) {
assert.NoError(t, err)
assert.EqualValues(t, "pr-1|upstream", actualEntry[0].value)
assert.EqualValues(t, "Remote: upstream", actualEntry[0].label)