From bf9339557eb5ac4f0a0f845dadf4c9311715712e Mon Sep 17 00:00:00 2001 From: Stefan Haller Date: Wed, 1 Jan 2025 13:29:35 +0100 Subject: [PATCH] Show the keybinding at bottom of commit description view It was hard to discover, this should make it more obvious. --- pkg/gui/controllers/commit_description_controller.go | 11 +++++++++++ pkg/gui/controllers/commit_message_controller.go | 6 ++++++ pkg/i18n/english.go | 2 ++ 3 files changed, 19 insertions(+) diff --git a/pkg/gui/controllers/commit_description_controller.go b/pkg/gui/controllers/commit_description_controller.go index 9f1fe78e5..aea6cfbdf 100644 --- a/pkg/gui/controllers/commit_description_controller.go +++ b/pkg/gui/controllers/commit_description_controller.go @@ -3,7 +3,9 @@ package controllers import ( "github.com/jesseduffield/gocui" "github.com/jesseduffield/lazygit/pkg/gui/context" + "github.com/jesseduffield/lazygit/pkg/gui/keybindings" "github.com/jesseduffield/lazygit/pkg/gui/types" + "github.com/jesseduffield/lazygit/pkg/utils" ) type CommitDescriptionController struct { @@ -59,6 +61,15 @@ func (self *CommitDescriptionController) GetMouseKeybindings(opts types.Keybindi } } +func (self *CommitDescriptionController) GetOnFocus() func(types.OnFocusOpts) { + return func(types.OnFocusOpts) { + self.c.Views().CommitDescription.Footer = utils.ResolvePlaceholderString(self.c.Tr.CommitDescriptionFooter, + map[string]string{ + "confirmInEditorKeybinding": keybindings.Label(self.c.UserConfig().Keybinding.Universal.ConfirmInEditor), + }) + } +} + func (self *CommitDescriptionController) switchToCommitMessage() error { self.c.Context().Replace(self.c.Contexts().CommitMessage) return nil diff --git a/pkg/gui/controllers/commit_message_controller.go b/pkg/gui/controllers/commit_message_controller.go index 93be127a0..28168ef18 100644 --- a/pkg/gui/controllers/commit_message_controller.go +++ b/pkg/gui/controllers/commit_message_controller.go @@ -69,6 +69,12 @@ func (self *CommitMessageController) GetMouseKeybindings(opts types.KeybindingsO } } +func (self *CommitMessageController) GetOnFocus() func(types.OnFocusOpts) { + return func(types.OnFocusOpts) { + self.c.Views().CommitDescription.Footer = "" + } +} + func (self *CommitMessageController) GetOnFocusLost() func(types.OnFocusLostOpts) { return func(types.OnFocusLostOpts) { self.context().RenderCommitLength() diff --git a/pkg/i18n/english.go b/pkg/i18n/english.go index 4eb91077f..e777bdc96 100644 --- a/pkg/i18n/english.go +++ b/pkg/i18n/english.go @@ -290,6 +290,7 @@ type TranslationSet struct { CommitSummaryTitle string CommitDescriptionTitle string CommitDescriptionSubTitle string + CommitDescriptionFooter string LocalBranchesTitle string SearchTitle string TagsTitle string @@ -1290,6 +1291,7 @@ func EnglishTranslationSet() *TranslationSet { CommitSummaryTitle: "Commit summary", CommitDescriptionTitle: "Commit description", CommitDescriptionSubTitle: "Press {{.togglePanelKeyBinding}} to toggle focus, {{.commitMenuKeybinding}} to open menu", + CommitDescriptionFooter: "Press {{.confirmInEditorKeybinding}} to commit", LocalBranchesTitle: "Local branches", SearchTitle: "Search", TagsTitle: "Tags",