1
0
mirror of https://github.com/jesseduffield/lazygit.git synced 2024-12-10 11:10:18 +02:00

rename SelectedLine to CurrentLine in tests

This commit is contained in:
Jesse Duffield 2022-12-26 10:42:19 +11:00
parent 5d2584a188
commit fa0414777f
22 changed files with 41 additions and 41 deletions

View File

@ -143,7 +143,7 @@ func (self *Assert) InListContext() {
}) })
} }
func (self *Assert) SelectedLine(matcher *matcher) { func (self *Assert) CurrentLine(matcher *matcher) {
self.matchString(matcher, "Unexpected selected line.", self.matchString(matcher, "Unexpected selected line.",
func() string { func() string {
return self.gui.CurrentContext().GetView().SelectedLine() return self.gui.CurrentContext().GetView().SelectedLine()
@ -151,7 +151,7 @@ func (self *Assert) SelectedLine(matcher *matcher) {
) )
} }
func (self *Assert) SelectedLineIdx(expected int) { func (self *Assert) CurrentLineIdx(expected int) {
self.assertWithRetries(func() (bool, string) { self.assertWithRetries(func() (bool, string) {
actual := self.gui.CurrentContext().GetView().SelectedLineIdx() actual := self.gui.CurrentContext().GetView().SelectedLineIdx()
return expected == actual, fmt.Sprintf("Expected selected line index to be %d, got %d", expected, actual) return expected == actual, fmt.Sprintf("Expected selected line index to be %d, got %d", expected, actual)

View File

@ -103,7 +103,7 @@ func (self *Input) PreviousItem() {
func (self *Input) ContinueMerge() { func (self *Input) ContinueMerge() {
self.Press(self.keys.Universal.CreateRebaseOptionsMenu) self.Press(self.keys.Universal.CreateRebaseOptionsMenu)
self.assert.SelectedLine(Contains("continue")) self.assert.CurrentLine(Contains("continue"))
self.Confirm() self.Confirm()
} }
@ -166,20 +166,20 @@ func (self *Input) NavigateToListItem(matcher *matcher) {
selectedLineIdx := view.SelectedLineIdx() selectedLineIdx := view.SelectedLineIdx()
if selectedLineIdx == matchIndex { if selectedLineIdx == matchIndex {
self.assert.SelectedLine(matcher) self.assert.CurrentLine(matcher)
return return
} }
if selectedLineIdx < matchIndex { if selectedLineIdx < matchIndex {
for i := selectedLineIdx; i < matchIndex; i++ { for i := selectedLineIdx; i < matchIndex; i++ {
self.NextItem() self.NextItem()
} }
self.assert.SelectedLine(matcher) self.assert.CurrentLine(matcher)
return return
} else { } else {
for i := selectedLineIdx; i > matchIndex; i-- { for i := selectedLineIdx; i > matchIndex; i-- {
self.PreviousItem() self.PreviousItem()
} }
self.assert.SelectedLine(matcher) self.assert.CurrentLine(matcher)
return return
} }
} }
@ -213,7 +213,7 @@ func (self *Input) Typeahead(title *matcher, textToType string, expectedFirstOpt
self.Type(textToType) self.Type(textToType)
self.Press(self.keys.Universal.TogglePanel) self.Press(self.keys.Universal.TogglePanel)
self.assert.CurrentViewName("suggestions") self.assert.CurrentViewName("suggestions")
self.assert.SelectedLine(expectedFirstOption) self.assert.CurrentLine(expectedFirstOption)
self.Confirm() self.Confirm()
} }

View File

@ -34,7 +34,7 @@ var Basic = NewIntegrationTest(NewIntegrationTestArgs{
input.SwitchToCommitsWindow() input.SwitchToCommitsWindow()
assert.SelectedLine(Contains("commit 10")) assert.CurrentLine(Contains("commit 10"))
input.NavigateToListItem(Contains("commit 09")) input.NavigateToListItem(Contains("commit 09"))
@ -43,7 +43,7 @@ var Basic = NewIntegrationTest(NewIntegrationTestArgs{
assert.ViewContent("information", Contains("bisecting")) assert.ViewContent("information", Contains("bisecting"))
assert.CurrentViewName("commits") assert.CurrentViewName("commits")
assert.SelectedLine(Contains("<-- bad")) assert.CurrentLine(Contains("<-- bad"))
input.NavigateToListItem(Contains("commit 02")) input.NavigateToListItem(Contains("commit 02"))
@ -51,14 +51,14 @@ var Basic = NewIntegrationTest(NewIntegrationTestArgs{
// lazygit will land us in the commit between our good and bad commits. // lazygit will land us in the commit between our good and bad commits.
assert.CurrentViewName("commits") assert.CurrentViewName("commits")
assert.SelectedLine(Contains("commit 05")) assert.CurrentLine(Contains("commit 05"))
assert.SelectedLine(Contains("<-- current")) assert.CurrentLine(Contains("<-- current"))
markCommitAsBad() markCommitAsBad()
assert.CurrentViewName("commits") assert.CurrentViewName("commits")
assert.SelectedLine(Contains("commit 04")) assert.CurrentLine(Contains("commit 04"))
assert.SelectedLine(Contains("<-- current")) assert.CurrentLine(Contains("<-- current"))
markCommitAsGood() markCommitAsGood()

View File

@ -40,6 +40,6 @@ var CheckoutByName = NewIntegrationTest(NewIntegrationTestArgs{
Contains("@"), Contains("@"),
) )
assert.SelectedLine(Contains("new-branch")) assert.CurrentLine(Contains("new-branch"))
}, },
}) })

View File

@ -39,6 +39,6 @@ var Delete = NewIntegrationTest(NewIntegrationTestArgs{
MatchesRegexp(`\*.*branch-two`), MatchesRegexp(`\*.*branch-two`),
MatchesRegexp(`master`), MatchesRegexp(`master`),
) )
assert.SelectedLineIdx(1) assert.CurrentLineIdx(1)
}, },
}) })

View File

@ -39,7 +39,7 @@ var Rebase = NewIntegrationTest(NewIntegrationTestArgs{
input.AcceptConfirmation(Equals("Auto-merge failed"), Contains("Conflicts!")) input.AcceptConfirmation(Equals("Auto-merge failed"), Contains("Conflicts!"))
assert.CurrentViewName("files") assert.CurrentViewName("files")
assert.SelectedLine(Contains("file")) assert.CurrentLine(Contains("file"))
// not using Confirm() convenience method because I suspect we might change this // not using Confirm() convenience method because I suspect we might change this
// keybinding to something more bespoke // keybinding to something more bespoke

View File

@ -46,7 +46,7 @@ var RebaseAndDrop = NewIntegrationTest(NewIntegrationTestArgs{
input.AcceptConfirmation(Equals("Auto-merge failed"), Contains("Conflicts!")) input.AcceptConfirmation(Equals("Auto-merge failed"), Contains("Conflicts!"))
assert.CurrentViewName("files") assert.CurrentViewName("files")
assert.SelectedLine(Contains("file")) assert.CurrentLine(Contains("file"))
input.SwitchToCommitsWindow() input.SwitchToCommitsWindow()
assert.ViewTopLines( assert.ViewTopLines(
@ -57,10 +57,10 @@ var RebaseAndDrop = NewIntegrationTest(NewIntegrationTestArgs{
MatchesRegexp("second change"), MatchesRegexp("second change"),
MatchesRegexp("original"), MatchesRegexp("original"),
) )
assert.SelectedLineIdx(0) assert.CurrentLineIdx(0)
input.NextItem() input.NextItem()
input.Press(keys.Universal.Remove) input.Press(keys.Universal.Remove)
assert.SelectedLine(MatchesRegexp(`drop.*to remove`)) assert.CurrentLine(MatchesRegexp(`drop.*to remove`))
input.SwitchToFilesWindow() input.SwitchToFilesWindow()

View File

@ -55,7 +55,7 @@ var CherryPickConflicts = NewIntegrationTest(NewIntegrationTestArgs{
input.AcceptConfirmation(Equals("Auto-merge failed"), Contains("Conflicts!")) input.AcceptConfirmation(Equals("Auto-merge failed"), Contains("Conflicts!"))
assert.CurrentViewName("files") assert.CurrentViewName("files")
assert.SelectedLine(Contains("file")) assert.CurrentLine(Contains("file"))
// not using Confirm() convenience method because I suspect we might change this // not using Confirm() convenience method because I suspect we might change this
// keybinding to something more bespoke // keybinding to something more bespoke

View File

@ -19,7 +19,7 @@ var Staged = NewIntegrationTest(NewIntegrationTestArgs{
assert.CommitCount(0) assert.CommitCount(0)
assert.CurrentViewName("files") assert.CurrentViewName("files")
assert.SelectedLine(Contains("myfile")) assert.CurrentLine(Contains("myfile"))
// stage the file // stage the file
input.PrimaryAction() input.PrimaryAction()
input.Enter() input.Enter()

View File

@ -20,7 +20,7 @@ var StagedWithoutHooks = NewIntegrationTest(NewIntegrationTestArgs{
// stage the file // stage the file
assert.CurrentViewName("files") assert.CurrentViewName("files")
assert.SelectedLine(Contains("myfile")) assert.CurrentLine(Contains("myfile"))
input.PrimaryAction() input.PrimaryAction()
input.Enter() input.Enter()
assert.CurrentViewName("stagingSecondary") assert.CurrentViewName("stagingSecondary")

View File

@ -21,7 +21,7 @@ var Unstaged = NewIntegrationTest(NewIntegrationTestArgs{
assert.CommitCount(0) assert.CommitCount(0)
assert.CurrentViewName("files") assert.CurrentViewName("files")
assert.SelectedLine(Contains("myfile")) assert.CurrentLine(Contains("myfile"))
input.Enter() input.Enter()
assert.CurrentViewName("staging") assert.CurrentViewName("staging")
assert.ViewContent("stagingSecondary", NotContains("+myfile content")) assert.ViewContent("stagingSecondary", NotContains("+myfile content"))

View File

@ -31,6 +31,6 @@ var Basic = NewIntegrationTest(NewIntegrationTestArgs{
input.Press("a") input.Press("a")
assert.WorkingTreeFileCount(1) assert.WorkingTreeFileCount(1)
assert.SelectedLine(Contains("myfile")) assert.CurrentLine(Contains("myfile"))
}, },
}) })

View File

@ -72,7 +72,7 @@ var FormPrompts = NewIntegrationTest(NewIntegrationTestArgs{
input.AcceptConfirmation(Equals("Are you sure?"), Equals("Are you REALLY sure you want to make this file? Up to you buddy.")) input.AcceptConfirmation(Equals("Are you sure?"), Equals("Are you REALLY sure you want to make this file? Up to you buddy."))
assert.WorkingTreeFileCount(1) assert.WorkingTreeFileCount(1)
assert.SelectedLine(Contains("my file")) assert.CurrentLine(Contains("my file"))
assert.MainViewContent(Contains(`"BAR"`)) assert.MainViewContent(Contains(`"BAR"`))
}, },
}) })

View File

@ -60,7 +60,7 @@ var MenuFromCommand = NewIntegrationTest(NewIntegrationTestArgs{
input.SwitchToFilesWindow() input.SwitchToFilesWindow()
assert.WorkingTreeFileCount(1) assert.WorkingTreeFileCount(1)
assert.SelectedLine(Contains("output.txt")) assert.CurrentLine(Contains("output.txt"))
assert.MainViewContent(Contains("bar Branch: #feature/foo my branch feature/foo")) assert.MainViewContent(Contains("bar Branch: #feature/foo my branch feature/foo"))
}, },
}) })

View File

@ -56,7 +56,7 @@ var MenuFromCommandsOutput = NewIntegrationTest(NewIntegrationTestArgs{
assert.InPrompt() assert.InPrompt()
assert.CurrentViewTitle(Equals("Which git command do you want to run?")) assert.CurrentViewTitle(Equals("Which git command do you want to run?"))
assert.SelectedLine(Equals("branch")) assert.CurrentLine(Equals("branch"))
input.Confirm() input.Confirm()
input.Menu(Equals("Branch:"), Equals("master")) input.Menu(Equals("Branch:"), Equals("master"))

View File

@ -70,7 +70,7 @@ var MultiplePrompts = NewIntegrationTest(NewIntegrationTestArgs{
input.AcceptConfirmation(Equals("Are you sure?"), Equals("Are you REALLY sure you want to make this file? Up to you buddy.")) input.AcceptConfirmation(Equals("Are you sure?"), Equals("Are you REALLY sure you want to make this file? Up to you buddy."))
assert.WorkingTreeFileCount(1) assert.WorkingTreeFileCount(1)
assert.SelectedLine(Contains("myfile")) assert.CurrentLine(Contains("myfile"))
assert.MainViewContent(Contains("BAR")) assert.MainViewContent(Contains("BAR"))
}, },
}) })

View File

@ -42,10 +42,10 @@ var Diff = NewIntegrationTest(NewIntegrationTestArgs{
input.Enter() input.Enter()
assert.CurrentViewName("subCommits") assert.CurrentViewName("subCommits")
assert.MainViewContent(Contains("+second line")) assert.MainViewContent(Contains("+second line"))
assert.SelectedLine(Contains("update")) assert.CurrentLine(Contains("update"))
input.Enter() input.Enter()
assert.CurrentViewName("commitFiles") assert.CurrentViewName("commitFiles")
assert.SelectedLine(Contains("file1")) assert.CurrentLine(Contains("file1"))
assert.MainViewContent(Contains("+second line")) assert.MainViewContent(Contains("+second line"))
input.Press(keys.Universal.Return) input.Press(keys.Universal.Return)

View File

@ -43,10 +43,10 @@ var DiffAndApplyPatch = NewIntegrationTest(NewIntegrationTestArgs{
input.Enter() input.Enter()
assert.CurrentViewName("subCommits") assert.CurrentViewName("subCommits")
assert.MainViewContent(Contains("+second line")) assert.MainViewContent(Contains("+second line"))
assert.SelectedLine(Contains("update")) assert.CurrentLine(Contains("update"))
input.Enter() input.Enter()
assert.CurrentViewName("commitFiles") assert.CurrentViewName("commitFiles")
assert.SelectedLine(Contains("file1")) assert.CurrentLine(Contains("file1"))
assert.MainViewContent(Contains("+second line")) assert.MainViewContent(Contains("+second line"))
// add the file to the patch // add the file to the patch
@ -63,7 +63,7 @@ var DiffAndApplyPatch = NewIntegrationTest(NewIntegrationTestArgs{
input.SwitchToFilesWindow() input.SwitchToFilesWindow()
assert.SelectedLine(Contains("file1")) assert.CurrentLine(Contains("file1"))
assert.MainViewContent(Contains("+second line")) assert.MainViewContent(Contains("+second line"))
}, },
}) })

View File

@ -37,7 +37,7 @@ var DiffCommits = NewIntegrationTest(NewIntegrationTestArgs{
input.NextItem() input.NextItem()
input.NextItem() input.NextItem()
assert.SelectedLine(Contains("first commit")) assert.CurrentLine(Contains("first commit"))
assert.MainViewContent(Contains("-second line\n-third line")) assert.MainViewContent(Contains("-second line\n-third line"))
@ -50,7 +50,7 @@ var DiffCommits = NewIntegrationTest(NewIntegrationTestArgs{
input.Enter() input.Enter()
assert.CurrentViewName("commitFiles") assert.CurrentViewName("commitFiles")
assert.SelectedLine(Contains("file1")) assert.CurrentLine(Contains("file1"))
assert.MainViewContent(Contains("+second line\n+third line")) assert.MainViewContent(Contains("+second line\n+third line"))
}, },
}) })

View File

@ -82,7 +82,7 @@ var DiscardChanges = NewIntegrationTest(NewIntegrationTestArgs{
discardOneByOne := func(files []statusFile) { discardOneByOne := func(files []statusFile) {
for _, file := range files { for _, file := range files {
assert.SelectedLine(Contains(file.status + " " + file.label)) assert.CurrentLine(Contains(file.status + " " + file.label))
input.Press(keys.Universal.Remove) input.Press(keys.Universal.Remove)
input.Menu(Equals(file.menuTitle), Contains("discard all changes")) input.Menu(Equals(file.menuTitle), Contains("discard all changes"))
} }

View File

@ -20,19 +20,19 @@ var One = NewIntegrationTest(NewIntegrationTestArgs{
input.NavigateToListItem(Contains("commit 02")) input.NavigateToListItem(Contains("commit 02"))
input.Press(keys.Universal.Edit) input.Press(keys.Universal.Edit)
assert.SelectedLine(Contains("YOU ARE HERE")) assert.CurrentLine(Contains("YOU ARE HERE"))
input.PreviousItem() input.PreviousItem()
input.Press(keys.Commits.MarkCommitAsFixup) input.Press(keys.Commits.MarkCommitAsFixup)
assert.SelectedLine(Contains("fixup")) assert.CurrentLine(Contains("fixup"))
input.PreviousItem() input.PreviousItem()
input.Press(keys.Universal.Remove) input.Press(keys.Universal.Remove)
assert.SelectedLine(Contains("drop")) assert.CurrentLine(Contains("drop"))
input.PreviousItem() input.PreviousItem()
input.Press(keys.Commits.SquashDown) input.Press(keys.Commits.SquashDown)
assert.SelectedLine(Contains("squash")) assert.CurrentLine(Contains("squash"))
input.ContinueRebase() input.ContinueRebase()

View File

@ -31,6 +31,6 @@ var Rename = NewIntegrationTest(NewIntegrationTestArgs{
input.Prompt(Equals("Rename stash: stash@{1}"), " baz") input.Prompt(Equals("Rename stash: stash@{1}"), " baz")
assert.SelectedLine(Equals("On master: foo baz")) assert.CurrentLine(Equals("On master: foo baz"))
}, },
}) })