1
0
mirror of https://github.com/jesseduffield/lazygit.git synced 2025-06-15 00:15:32 +02:00
Commit Graph

101 Commits

Author SHA1 Message Date
e4e16fa38e Change OpenCommand to Open and OpenLinkCommand to OpenLink
We do this for consistency with the edit settings. The old names are kept as a
fallback for now.
2023-04-13 13:14:00 +02:00
b7e029adc7 Don't set platform defaults on OSConfig struct immediately
Instead, query the platform defaults only if the config is empty. This will be
necessary later to distinguish an empty config from a default config, so that we
can give deprecation warnings.
2023-04-13 13:14:00 +02:00
08d679c3a8 Remove line number support for "open" command
The "open" command is supposed to behave in the same way as double-clicking a
file in the Finder/Explorer. The concept of jumping to a specific line in the
file doesn't make sense for this; use "edit" instead.
2023-04-13 13:14:00 +02:00
24de156592 Fix windows tests
Now that the tests run again, it turns out that they actually fail, so fix them.
2023-04-13 13:14:00 +02:00
8d3cce4a49 Rename test files so that test discovery works again
These files were renamed from os_windows_test.go to os_test_windows.go (etc.) in
95b2e9540a. Since then, the tests have no longer run, since go only looks for
tests in files ending with "test.go".

It isn't important that the file name ends with "_windows.go", since there are
already build constrains in the files themselves.
2023-04-13 13:14:00 +02:00
e6274af015 appease golangci-lint (#2512) 2023-03-19 11:20:29 +11:00
8dbd7d44ff Fix checking for credentials performance (#2452)
Co-authored-by: Jesse Duffield <jessedduffield@gmail.com>
2023-03-19 11:08:54 +11:00
1a1f042f49 Add credential prompts for U2F-backed SSH keys
The 8.2 release of OpenSSH added support for FIDO/U2F hardware
authenticators, which manifests in being able to create new types of SSH
key, named `ecdsa-sk` nad `ed25519-sk`. This is relevant to lazygit,
as those SSH keys can be used to authorise git operations over SSH, as
well as signing git commits. Actual code changes are required for
correct support, as the authentication process for these types of keys
is different than the process for types supported previously.

When an operation requiring credentials is initialised with a U2F
authenticator-backed key, the first prompt is:

	Enter PIN for ${key_type} key ${path_to_key}:

at which point the user is supposed to enter a numeric (and secret) PIN,
specific to the particular FIDO/U2F authenticator using which the SSH
keypair was generated. Upon entering the correct key, the user is
supposed to physically interact with the authenticator to confirm
presence. Sometimes this is accompanied by the following text prompt:

	Confirm user presence for key ${key_type} ${key_fingerprint}

This second prompt does not always occur and it is presumed that the
user will know to perform this step even if not prompted specifically.
At this stage some authenticator devices may also begin to blink a LED
to indicate that they're waiting for input.

To facilitate lazygit's interoperability with these types of keys, add
support for the first PIN prompt, which allows "fetch", "pull", and
"push" git operations to complete.
2022-11-30 13:34:32 +11:00
df3cd941d7 use tempdir in tests to prevent polluting worktree 2022-11-13 14:10:21 +11:00
fd66499c8f Merge pull request #2167 from xiaoliwang/remove_deprecated 2022-09-23 23:01:40 -07:00
438038a4f1 fix(loaders/file.go): changed to ignore stderr when loading git status 2022-09-19 18:46:32 +09:00
3d79c6a3d3 formatter 2022-09-17 15:10:41 -07:00
b8900baf1a remove deprecated calls 2022-09-17 15:10:41 -07:00
d78d694959 chore: remove duplicate word in comments
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
2022-08-30 13:23:37 +08:00
b77f3160f1 Merge pull request #2004 from mark2185/fix-add-to-gitignore-newline 2022-08-07 12:49:39 +10:00
755ae0ef84 add deadlock mutex package
write to deadlock stderr after closing gocui

more deadlock checking
2022-08-07 11:16:14 +10:00
7410acd1aa move merge conflicts code into controller 2022-08-07 11:16:03 +10:00
fdf6a9cc2b Test appending to empty file 2022-08-04 13:52:04 +02:00
6160d85d4f Use tmpdir for tests 2022-08-03 14:06:12 +02:00
64224e7caa Update pkg/commands/oscommands/os.go
Co-authored-by: Ryoga <eial5q265e5+github@gmail.com>
2022-08-03 13:57:26 +02:00
d56bb0b8ef Fix the integration test 2022-08-03 07:55:51 +02:00
d238d8952b Add AppendLineToFile tests 2022-08-03 07:55:51 +02:00
86d5654d20 Preserve trailing newline setting when adding to gitignore 2022-08-03 07:55:51 +02:00
86ac309e08 add build info when building from source 2022-08-01 20:16:50 +10:00
c9d891a913 better process killing 2022-06-18 13:39:22 +10:00
02c5559704 run integration tests in parallel and properly cache windows build 2022-06-11 13:06:29 +10:00
86c259623c feat: fix permission problem of temp dirs 2022-04-02 08:48:38 +11:00
2fbb52fa2c chore: remove dead code 2022-04-02 08:48:38 +11:00
7128d822cb show stdout in error message if stderr is blank 2022-03-27 14:58:20 +11:00
f9979879a1 no more naked returns 2022-03-25 23:27:28 +11:00
bf4f06ab4e more generics 2022-03-24 20:14:41 +11:00
a34bdf1a04 update linters 2022-03-19 12:12:57 +11:00
d991d74b06 add commit message controller 2022-03-17 19:13:40 +11:00
cd31a762b9 rename OSCommand field to os 2022-03-17 19:13:40 +11:00
1dd7307fde start moving commit panel handlers into controller
more

and more

move rebase commit refreshing into existing abstraction

and more

and more

WIP

and more

handling clicks

properly fix merge conflicts

update cheatsheet

lots more preparation to start moving things into controllers

WIP

better typing

expand on remotes controller

moving more code into controllers
2022-03-17 19:13:40 +11:00
4ab5e54139 add support for git bisect 2022-01-22 10:48:51 +11:00
a78cbf4882 remove redundant title-setting shell command args 2022-01-21 23:13:39 +11:00
62a7d9bbcc invoke title-setting shell command appropriately 2022-01-21 23:13:39 +11:00
555d8bbc96 set repo name as window title when loading repo, fix #1691 2022-01-21 23:13:39 +11:00
cdcfeb396f stop refreshing the screen so much 2022-01-15 14:15:41 +11:00
a936c0592f more refactoring 2022-01-09 14:09:53 +11:00
4d80c87736 use a string builder for credential checking 2022-01-09 14:09:53 +11:00
267ecbe694 refactor code for handling credential requests 2022-01-09 14:09:53 +11:00
18f48a43d5 add some more linters 2022-01-09 14:09:53 +11:00
fdf79fdeee fix bug that caused credentials popup to be raised unexpectedly 2022-01-09 14:09:53 +11:00
3621854dc7 fix tests 2022-01-09 14:09:53 +11:00
007235df23 refactor 2022-01-09 14:09:53 +11:00
f503ff1ecb start breaking up git struct 2022-01-09 14:09:53 +11:00
93729ba61b fix some things 2022-01-07 10:52:51 +11:00
91fe68576c refactor 2022-01-07 10:52:51 +11:00