mirror of
https://github.com/jesseduffield/lazygit.git
synced 2024-12-12 11:15:00 +02:00
63dc07fded
By constructing an arg vector manually, we no longer need to quote arguments Mandate that args must be passed when building a command Now you need to provide an args array when building a command. There are a handful of places where we need to deal with a string, such as with user-defined custom commands, and for those we now require that at the callsite they use str.ToArgv to do that. I don't want to provide a method out of the box for it because I want to discourage its use. For some reason we were invoking a command through a shell when amending a commit, and I don't believe we needed to do that as there was nothing user- supplied about the command. So I've switched to using a regular command out- side the shell there
60 lines
1.4 KiB
Go
60 lines
1.4 KiB
Go
package git_commands
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/jesseduffield/lazygit/pkg/commands/models"
|
|
"github.com/jesseduffield/lazygit/pkg/commands/oscommands"
|
|
"github.com/jesseduffield/lazygit/pkg/utils"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestGetStashEntries(t *testing.T) {
|
|
type scenario struct {
|
|
testName string
|
|
filterPath string
|
|
runner oscommands.ICmdObjRunner
|
|
expectedStashEntries []*models.StashEntry
|
|
}
|
|
|
|
scenarios := []scenario{
|
|
{
|
|
"No stash entries found",
|
|
"",
|
|
oscommands.NewFakeRunner(t).
|
|
ExpectGitArgs([]string{"stash", "list", "-z", "--pretty=%gs"}, "", nil),
|
|
[]*models.StashEntry{},
|
|
},
|
|
{
|
|
"Several stash entries found",
|
|
"",
|
|
oscommands.NewFakeRunner(t).
|
|
ExpectGitArgs([]string{"stash", "list", "-z", "--pretty=%gs"},
|
|
"WIP on add-pkg-commands-test: 55c6af2 increase parallel build\x00WIP on master: bb86a3f update github template\x00",
|
|
nil,
|
|
),
|
|
[]*models.StashEntry{
|
|
{
|
|
Index: 0,
|
|
Name: "WIP on add-pkg-commands-test: 55c6af2 increase parallel build",
|
|
},
|
|
{
|
|
Index: 1,
|
|
Name: "WIP on master: bb86a3f update github template",
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, s := range scenarios {
|
|
s := s
|
|
t.Run(s.testName, func(t *testing.T) {
|
|
cmd := oscommands.NewDummyCmdObjBuilder(s.runner)
|
|
|
|
loader := NewStashLoader(utils.NewDummyCommon(), cmd)
|
|
|
|
assert.EqualValues(t, s.expectedStashEntries, loader.GetStashEntries(s.filterPath))
|
|
})
|
|
}
|
|
}
|