mirror of
https://github.com/jesseduffield/lazygit.git
synced 2025-04-23 12:18:51 +02:00
63dc07fded
By constructing an arg vector manually, we no longer need to quote arguments Mandate that args must be passed when building a command Now you need to provide an args array when building a command. There are a handful of places where we need to deal with a string, such as with user-defined custom commands, and for those we now require that at the callsite they use str.ToArgv to do that. I don't want to provide a method out of the box for it because I want to discourage its use. For some reason we were invoking a command through a shell when amending a commit, and I don't believe we needed to do that as there was nothing user- supplied about the command. So I've switched to using a regular command out- side the shell there
54 lines
1.5 KiB
Go
54 lines
1.5 KiB
Go
package commit
|
|
|
|
import (
|
|
"github.com/jesseduffield/lazygit/pkg/config"
|
|
. "github.com/jesseduffield/lazygit/pkg/integration/components"
|
|
)
|
|
|
|
var History = NewIntegrationTest(NewIntegrationTestArgs{
|
|
Description: "Cycling through commit message history in the commit message panel",
|
|
ExtraCmdArgs: []string{},
|
|
Skip: false,
|
|
SetupConfig: func(config *config.AppConfig) {},
|
|
SetupRepo: func(shell *Shell) {
|
|
shell.EmptyCommit("initial commit")
|
|
shell.EmptyCommit("commit 2")
|
|
shell.EmptyCommit("commit 3")
|
|
|
|
shell.CreateFile("myfile", "myfile content")
|
|
},
|
|
Run: func(t *TestDriver, keys config.KeybindingConfig) {
|
|
t.Views().Files().
|
|
IsFocused().
|
|
PressPrimaryAction(). // stage file
|
|
Press(keys.Files.CommitChanges)
|
|
|
|
t.ExpectPopup().CommitMessagePanel().
|
|
InitialText(Equals("")).
|
|
Type("my commit message").
|
|
SelectPreviousMessage().
|
|
Content(Equals("commit 3")).
|
|
SelectPreviousMessage().
|
|
Content(Equals("commit 2")).
|
|
SelectPreviousMessage().
|
|
Content(Equals("initial commit")).
|
|
SelectPreviousMessage().
|
|
Content(Equals("initial commit")). // we hit the end
|
|
SelectNextMessage().
|
|
Content(Equals("commit 2")).
|
|
SelectNextMessage().
|
|
Content(Equals("commit 3")).
|
|
SelectNextMessage().
|
|
Content(Equals("my commit message")).
|
|
SelectNextMessage().
|
|
Content(Equals("my commit message")). // we hit the beginning
|
|
Type(" with extra added").
|
|
Confirm()
|
|
|
|
t.Views().Commits().
|
|
TopLines(
|
|
Contains("my commit message with extra added").IsSelected(),
|
|
)
|
|
},
|
|
})
|