mirror of
https://github.com/jesseduffield/lazygit.git
synced 2024-12-14 11:23:09 +02:00
63dc07fded
By constructing an arg vector manually, we no longer need to quote arguments Mandate that args must be passed when building a command Now you need to provide an args array when building a command. There are a handful of places where we need to deal with a string, such as with user-defined custom commands, and for those we now require that at the callsite they use str.ToArgv to do that. I don't want to provide a method out of the box for it because I want to discourage its use. For some reason we were invoking a command through a shell when amending a commit, and I don't believe we needed to do that as there was nothing user- supplied about the command. So I've switched to using a regular command out- side the shell there
143 lines
3.2 KiB
Go
143 lines
3.2 KiB
Go
//go:build !windows
|
|
// +build !windows
|
|
|
|
package oscommands
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/go-errors/errors"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestOSCommandRunWithOutput(t *testing.T) {
|
|
type scenario struct {
|
|
args []string
|
|
test func(string, error)
|
|
}
|
|
|
|
scenarios := []scenario{
|
|
{
|
|
[]string{"echo", "-n", "123"},
|
|
func(output string, err error) {
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, "123", output)
|
|
},
|
|
},
|
|
{
|
|
[]string{"rmdir", "unexisting-folder"},
|
|
func(output string, err error) {
|
|
assert.Regexp(t, "rmdir.*unexisting-folder.*", err.Error())
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, s := range scenarios {
|
|
c := NewDummyOSCommand()
|
|
s.test(c.Cmd.New(s.args).RunWithOutput())
|
|
}
|
|
}
|
|
|
|
func TestOSCommandOpenFileDarwin(t *testing.T) {
|
|
type scenario struct {
|
|
filename string
|
|
runner *FakeCmdObjRunner
|
|
test func(error)
|
|
}
|
|
|
|
scenarios := []scenario{
|
|
{
|
|
filename: "test",
|
|
runner: NewFakeRunner(t).
|
|
ExpectArgs([]string{"bash", "-c", `open "test"`}, "", errors.New("error")),
|
|
test: func(err error) {
|
|
assert.Error(t, err)
|
|
},
|
|
},
|
|
{
|
|
filename: "test",
|
|
runner: NewFakeRunner(t).
|
|
ExpectArgs([]string{"bash", "-c", `open "test"`}, "", nil),
|
|
test: func(err error) {
|
|
assert.NoError(t, err)
|
|
},
|
|
},
|
|
{
|
|
filename: "filename with spaces",
|
|
runner: NewFakeRunner(t).
|
|
ExpectArgs([]string{"bash", "-c", `open "filename with spaces"`}, "", nil),
|
|
test: func(err error) {
|
|
assert.NoError(t, err)
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, s := range scenarios {
|
|
oSCmd := NewDummyOSCommandWithRunner(s.runner)
|
|
oSCmd.Platform.OS = "darwin"
|
|
oSCmd.UserConfig.OS.Open = "open {{filename}}"
|
|
|
|
s.test(oSCmd.OpenFile(s.filename))
|
|
}
|
|
}
|
|
|
|
// TestOSCommandOpenFileLinux tests the OpenFile command on Linux
|
|
func TestOSCommandOpenFileLinux(t *testing.T) {
|
|
type scenario struct {
|
|
filename string
|
|
runner *FakeCmdObjRunner
|
|
test func(error)
|
|
}
|
|
|
|
scenarios := []scenario{
|
|
{
|
|
filename: "test",
|
|
runner: NewFakeRunner(t).
|
|
ExpectArgs([]string{"bash", "-c", `xdg-open "test" > /dev/null`}, "", errors.New("error")),
|
|
test: func(err error) {
|
|
assert.Error(t, err)
|
|
},
|
|
},
|
|
{
|
|
filename: "test",
|
|
runner: NewFakeRunner(t).
|
|
ExpectArgs([]string{"bash", "-c", `xdg-open "test" > /dev/null`}, "", nil),
|
|
test: func(err error) {
|
|
assert.NoError(t, err)
|
|
},
|
|
},
|
|
{
|
|
filename: "filename with spaces",
|
|
runner: NewFakeRunner(t).
|
|
ExpectArgs([]string{"bash", "-c", `xdg-open "filename with spaces" > /dev/null`}, "", nil),
|
|
test: func(err error) {
|
|
assert.NoError(t, err)
|
|
},
|
|
},
|
|
{
|
|
filename: "let's_test_with_single_quote",
|
|
runner: NewFakeRunner(t).
|
|
ExpectArgs([]string{"bash", "-c", `xdg-open "let's_test_with_single_quote" > /dev/null`}, "", nil),
|
|
test: func(err error) {
|
|
assert.NoError(t, err)
|
|
},
|
|
},
|
|
{
|
|
filename: "$USER.txt",
|
|
runner: NewFakeRunner(t).
|
|
ExpectArgs([]string{"bash", "-c", `xdg-open "\$USER.txt" > /dev/null`}, "", nil),
|
|
test: func(err error) {
|
|
assert.NoError(t, err)
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, s := range scenarios {
|
|
oSCmd := NewDummyOSCommandWithRunner(s.runner)
|
|
oSCmd.Platform.OS = "linux"
|
|
oSCmd.UserConfig.OS.Open = `xdg-open {{filename}} > /dev/null`
|
|
|
|
s.test(oSCmd.OpenFile(s.filename))
|
|
}
|
|
}
|