1
0
mirror of https://github.com/jesseduffield/lazygit.git synced 2025-01-08 04:04:22 +02:00
lazygit/pkg/gui/controllers
Stefan Haller b35f8776e1 Warn when there are hunks with only added lines
The algorithm works by blaming the deleted lines, so if a hunk contains only
added lines, we can only hope that it also belongs in the same commit. Warn the
user about this.

Note: the warning might be overly agressive, we'll have to see if this is
annoying. The reason is that it depends on the diff context size whether added
lines go into their own hunk or are grouped together with other added or deleted
lines into one hunk. However, our algorithm uses a diff context size of 0,
because that makes it easiest to parse the diff; this results in hunks having
only added lines more often than what the user sees. For example, moving a line
of code down by two lines will likely result in a single hunk for the user, but
in two hunks for our algorithm. On the other hand, being this strict makes the
warning consistent. We could consider using the user's diff context size in the
algorithm, but then it would depend on the current context size whether the
warning appears, which could be confusing. Plus, it would make the algorithm
quite a bit more complicated.
2024-01-10 09:11:40 +01:00
..
helpers Warn when there are hunks with only added lines 2024-01-10 09:11:40 +01:00
attach.go Begin refactoring gui 2023-04-30 13:19:52 +10:00
base_controller.go Begin refactoring gui 2023-04-30 13:19:52 +10:00
basic_commits_controller.go Add command to open git difftool 2024-01-09 14:27:33 +01:00
bisect_controller.go When bisecting, always mark the current commit as good/bad, not the selected 2023-07-29 14:44:00 +02:00
branches_controller.go Add a sort order menu for local branches 2023-12-27 15:25:29 +01:00
command_log_controller.go lots of changes 2023-04-30 13:19:53 +10:00
commit_description_controller.go Add key binding for switching from the commit message panel to an editor 2023-08-21 10:03:34 +02:00
commit_message_controller.go Add key binding for switching from the commit message panel to an editor 2023-08-21 10:03:34 +02:00
commits_files_controller.go Add command to open git difftool 2024-01-09 14:27:33 +01:00
common.go lots of changes 2023-04-30 13:19:53 +10:00
confirmation_controller.go Use sentence case everywhere 2023-05-25 23:52:19 +10:00
context_lines_controller.go Move diff context size from UserConfig to AppState 2023-09-05 13:55:30 +02:00
custom_command_action.go Standardise on using lo for slice functions 2023-07-30 18:51:23 +10:00
custom_patch_options_menu_action.go Show error when trying to open patch menu with an empty patch 2023-07-26 14:27:18 +02:00
diffing_menu_action.go fix: typo EnteRefName 2023-06-28 18:54:21 +06:00
files_controller.go Add command to find base commit for creating a fixup 2024-01-10 09:11:40 +01:00
files_remove_controller.go Support custom keybindings for confirm discard 2023-08-25 08:50:05 -05:00
filter_controller.go Introduce filtered list view model 2023-07-03 12:54:13 +10:00
filtering_menu_action.go Use sentence case everywhere 2023-05-25 23:52:19 +10:00
git_flow_controller.go Use sentence case everywhere 2023-05-25 23:52:19 +10:00
global_controller.go Use sentence case everywhere 2023-05-25 23:52:19 +10:00
jump_to_side_window_controller.go move side window actions to controllers package 2023-04-30 13:19:53 +10:00
list_controller.go Add a mechanism to insert non-model items into list contexts 2023-08-29 08:04:47 +02:00
local_commits_controller.go Add WithWaitingStatusSync for reverting commits 2023-12-09 15:28:41 +01:00
menu_controller.go Add DisabledReason field to MenuItem 2023-09-18 10:15:11 +02:00
merge_conflicts_controller.go Moves log related translations into its own Tr.Log. namespace 2023-07-31 19:42:41 -04:00
options_menu_action.go Add Enabled func to Binding 2023-09-18 10:20:23 +02:00
patch_building_controller.go Use sentence case everywhere 2023-05-25 23:52:19 +10:00
patch_explorer_controller.go Pass UserConfig to checkScrollUp/Down instead of just the scrollOffMargin 2023-08-21 08:10:28 +02:00
quit_actions.go Update repo switch logic 2023-07-30 18:35:23 +10:00
reflog_commits_controller.go Don't pass ignoreWhitespace to git commands 2023-09-04 17:50:49 +02:00
remote_branches_controller.go Add a sort order menu for local branches 2023-12-27 15:25:29 +01:00
remotes_controller.go feat: add jump-to-panel label setting 2023-09-09 09:45:08 +02:00
screen_mode_actions.go Remove special code to rerender views on screen mode change 2023-10-16 09:03:07 +02:00
scroll_off_margin_test.go Add tests for scroll-off margin of zero 2023-08-21 08:10:28 +02:00
scroll_off_margin.go Add scrollOffEnabled config 2023-08-21 09:03:45 +02:00
search_controller.go Introduce filtered list view model 2023-07-03 12:54:13 +10:00
search_prompt_controller.go Add search history 2023-09-20 08:35:41 +03:00
side_window_controller.go move side window actions to controllers package 2023-04-30 13:19:53 +10:00
snake_controller.go lots of changes 2023-04-30 13:19:53 +10:00
staging_controller.go Rename "Delete change" menu entry to "Discard change" in staging panel 2023-06-26 08:19:58 +02:00
stash_controller.go Don't pass ignoreWhitespace to git commands 2023-09-04 17:50:49 +02:00
status_controller.go Pass "now" into utils.Loader 2023-10-16 09:03:07 +02:00
sub_commits_controller.go Don't pass ignoreWhitespace to git commands 2023-09-04 17:50:49 +02:00
submodules_controller.go Don't pass ignoreWhitespace to git commands 2023-09-04 17:50:49 +02:00
suggestions_controller.go lots of changes 2023-04-30 13:19:53 +10:00
switch_to_diff_files_controller.go feat: add jump-to-panel label setting 2023-09-09 09:45:08 +02:00
switch_to_sub_commits_controller.go Add "Show divergence from upstream" entry to Upstream menu in branches panel 2023-08-29 08:16:40 +02:00
sync_controller.go Disallow pulling/pushing a branch while the branch is pushed or pulled 2023-10-08 18:45:36 +02:00
tags_controller.go Fix checking out a tag when a branch with the same name exists 2024-01-09 14:18:35 +01:00
toggle_whitespace_action.go Extract a SaveAppStateAndLogError function 2023-09-04 17:50:49 +02:00
types.go introduce Ref interface 2022-04-02 17:04:42 +11:00
undo_controller.go Replace uses of "git stash save" with "git stash push" 2023-07-10 15:09:17 +02:00
vertical_scroll_controller.go lots of changes 2023-04-30 13:19:53 +10:00
workspace_reset_controller.go Reset origin when clearing view 2023-08-08 22:01:43 +10:00
worktree_options_controller.go Support creating worktrees from refs 2023-07-30 18:35:22 +10:00
worktrees_controller.go Use fields rather than methods on worktrees 2023-07-30 18:35:24 +10:00