mirror of
https://github.com/jesseduffield/lazygit.git
synced 2025-01-06 03:53:59 +02:00
975d2bedb6
From the go 1.19 release notes:
Command and LookPath no longer allow results from a PATH search to be found relative to the current directory. This removes a common source of security problems but may also break existing programs that depend on using, say, exec.Command("prog") to run a binary named prog (or, on Windows, prog.exe) in the current directory. See the os/exec package documentation for information about how best to update such programs.
79 lines
1.8 KiB
Go
79 lines
1.8 KiB
Go
//go:build windows
|
|
// +build windows
|
|
|
|
package oscommands
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/go-errors/errors"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
// handling this in a separate file because str.ToArgv has different behaviour if we're on windows
|
|
|
|
func TestOSCommandOpenFileWindows(t *testing.T) {
|
|
type scenario struct {
|
|
filename string
|
|
runner *FakeCmdObjRunner
|
|
test func(error)
|
|
}
|
|
|
|
scenarios := []scenario{
|
|
{
|
|
filename: "test",
|
|
runner: NewFakeRunner(t).
|
|
ExpectArgs([]string{"cmd", "/c", "start", "", "test"}, "", errors.New("error")),
|
|
test: func(err error) {
|
|
assert.Error(t, err)
|
|
},
|
|
},
|
|
{
|
|
filename: "test",
|
|
runner: NewFakeRunner(t).
|
|
ExpectArgs([]string{"cmd", "/c", "start", "", "test"}, "", nil),
|
|
test: func(err error) {
|
|
assert.NoError(t, err)
|
|
},
|
|
},
|
|
{
|
|
filename: "filename with spaces",
|
|
runner: NewFakeRunner(t).
|
|
ExpectArgs([]string{"cmd", "/c", "start", "", "filename with spaces"}, "", nil),
|
|
test: func(err error) {
|
|
assert.NoError(t, err)
|
|
},
|
|
},
|
|
{
|
|
filename: "let's_test_with_single_quote",
|
|
runner: NewFakeRunner(t).
|
|
ExpectArgs([]string{"cmd", "/c", "start", "", "let's_test_with_single_quote"}, "", nil),
|
|
test: func(err error) {
|
|
assert.NoError(t, err)
|
|
},
|
|
},
|
|
{
|
|
filename: "$USER.txt",
|
|
runner: NewFakeRunner(t).
|
|
ExpectArgs([]string{"cmd", "/c", "start", "", "$USER.txt"}, "", nil),
|
|
test: func(err error) {
|
|
assert.NoError(t, err)
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, s := range scenarios {
|
|
oSCmd := NewDummyOSCommandWithRunner(s.runner)
|
|
platform := &Platform{
|
|
OS: "windows",
|
|
Shell: "cmd",
|
|
ShellArg: "/c",
|
|
}
|
|
oSCmd.Platform = platform
|
|
oSCmd.Cmd.platform = platform
|
|
oSCmd.UserConfig.OS.OpenCommand = `start "" {{filename}}`
|
|
|
|
s.test(oSCmd.OpenFile(s.filename))
|
|
}
|
|
}
|