Stefan Haller ca05a2ccea Enable revive linter, and fix a bunch of warnings ...

I took the set of enabled checks from revive's recommended configuration [1],
and removed some that I didn't like. There might be other useful checks in
revive that we might want to enable, but this is a nice improvement already.

The bulk of the changes here are removing unnecessary else statements after
returns, but there are a few others too.

[1] https://github.com/mgechev/revive?tab=readme-ov-file#recommended-configuration

2025-06-30 19:13:20 +02:00

..

bisect_info.go

rename sha to hash 2

2024-04-12 08:33:47 +02:00

bisect.go

rename sha to hash 9, case: Sha

2024-04-12 08:33:47 +02:00

blame.go

Add command to find base commit for creating a fixup

2024-01-10 09:11:40 +01:00

branch_loader_test.go

Remove canUsePushTrack parameter of obtainBranches function

2025-04-09 10:40:52 +02:00

branch_loader.go

Enable revive linter, and fix a bunch of warnings

2025-06-30 19:13:20 +02:00

branch_test.go

Allow deleting a range selection of branches

2024-12-01 10:59:54 +01:00

branch.go

Fix the CurrentBranchName function

2025-06-30 16:08:03 +02:00

commit_file_loader_test.go

Rename Name to Path in File and CommitFile

2025-03-20 12:31:34 +01:00

commit_file_loader.go

Rename Name to Path in File and CommitFile

2025-03-20 12:31:34 +01:00

commit_loader_test.go

Fix warning QF1004: could use strings.ReplaceAll instead

2025-06-30 18:30:11 +02:00

commit_loader.go

Remove ICmdObj interface

2025-05-01 15:21:37 +02:00

commit_test.go

Commit without pre-commit hooks is independent on prefix

2025-03-22 11:04:28 +01:00

commit.go

Enable revive linter, and fix a bunch of warnings

2025-06-30 19:13:20 +02:00

common.go

Remove sync mutex

2023-10-08 18:45:36 +02:00

config.go

fix: Make tag operation use GPG helper to run signing in sub-process

2025-03-24 08:41:58 +01:00

custom.go

Add runCommand function to Go template syntax

2025-04-09 10:44:36 +02:00

deps_test.go

Enable revive linter, and fix a bunch of warnings

2025-06-30 19:13:20 +02:00

diff.go

Remove ICmdObj interface

2025-05-01 15:21:37 +02:00

file_loader_test.go

Rename Name to Path in File and CommitFile

2025-03-20 12:31:34 +01:00

file_loader.go

Fix warning ST1016: methods on the same type should have the same receiver name

2025-06-30 18:30:11 +02:00

file_test.go

Support editing multiple files at once using range selection

2024-03-22 08:20:16 +01:00

file.go

Fix nvim-remote commands for fish shell

2025-04-27 20:12:11 +02:00

flow_test.go

Remove redundant variable dedeclarations

2024-05-19 16:38:21 +10:00

flow.go

Remove ICmdObj interface

2025-05-01 15:21:37 +02:00

git_command_builder_test.go

Add worktree tests for removing/detaching

2023-07-30 18:35:23 +10:00

git_command_builder.go

Enable revive linter, and fix a bunch of warnings

2025-06-30 19:13:20 +02:00

main_branches.go

Instantiate other mutexes by value

2025-06-19 18:39:46 +02:00

patch.go

Fix moving a custom patch from the very first commit of the history to a later commit

2025-06-19 18:43:17 +02:00

rebase_test.go

Remove ICmdObj interface

2025-05-01 15:21:37 +02:00

rebase.go

Enable revive linter, and fix a bunch of warnings

2025-06-30 19:13:20 +02:00

reflog_commit_loader_test.go

Fix warning QF1004: could use strings.ReplaceAll instead

2025-06-30 18:30:11 +02:00

reflog_commit_loader.go

Store Commit.Parents in the pool too

2025-04-29 14:57:15 +02:00

remote_loader.go

Use full refname instead of short to prevent disambiguation with tag

2025-06-04 20:43:01 +02:00

remote.go

Allow deleting a range selection of branches

2024-12-01 10:59:54 +01:00

repo_paths_test.go

Enable revive linter, and fix a bunch of warnings

2025-06-30 19:13:20 +02:00

repo_paths.go

Enable revive linter, and fix a bunch of warnings

2025-06-30 19:13:20 +02:00

stash_loader_test.go

Move NewDummyCommon to pkg/common

2025-05-06 09:43:26 +02:00

stash_loader.go

Make stashEntryFromLine a free-standing function

2025-06-30 18:30:11 +02:00

stash_test.go

Add unambigious refs/ prefix to all stash references

2025-06-15 16:14:59 +02:00

stash.go

Add unambigious refs/ prefix to all stash references

2025-06-15 16:14:59 +02:00

status.go

Make WorkingTreeState a struct, and add cherry-picking and reverting states

2025-04-20 15:53:17 +02:00

submodule.go

Enable revive linter, and fix a bunch of warnings

2025-06-30 19:13:20 +02:00

sync_test.go

Remove ICmdObj interface

2025-05-01 15:21:37 +02:00

sync.go

Remove ICmdObj interface

2025-05-01 15:21:37 +02:00

tag_loader_test.go

Add IsAnnotated field to models.Tag struct

2025-06-30 16:12:33 +02:00

tag_loader.go

Add IsAnnotated field to models.Tag struct

2025-06-30 16:12:33 +02:00

tag.go

Show tag information for selected tag

2025-06-30 16:12:33 +02:00

version_test.go

Add a method GitVersion.IsAtLeast

2024-01-10 09:18:38 +01:00

version.go

Add a method GitVersion.IsAtLeast

2024-01-10 09:18:38 +01:00

working_tree_test.go

Rename Name to Path in File and CommitFile

2025-03-20 12:31:34 +01:00

working_tree.go

Enable revive linter, and fix a bunch of warnings

2025-06-30 19:13:20 +02:00

worktree_loader_test.go

Remove redundant variable dedeclarations

2024-05-19 16:38:21 +10:00

worktree_loader.go

Remove redundant variable dedeclarations

2024-05-19 16:38:21 +10:00

worktree.go

Centralise logic for obtaining repo paths

2023-07-30 18:35:24 +10:00