mirror of
https://github.com/jesseduffield/lazygit.git
synced 2024-12-12 11:15:00 +02:00
63dc07fded
By constructing an arg vector manually, we no longer need to quote arguments Mandate that args must be passed when building a command Now you need to provide an args array when building a command. There are a handful of places where we need to deal with a string, such as with user-defined custom commands, and for those we now require that at the callsite they use str.ToArgv to do that. I don't want to provide a method out of the box for it because I want to discourage its use. For some reason we were invoking a command through a shell when amending a commit, and I don't believe we needed to do that as there was nothing user- supplied about the command. So I've switched to using a regular command out- side the shell there
21 lines
582 B
Go
21 lines
582 B
Go
package git_commands
|
|
|
|
import "github.com/mgutz/str"
|
|
|
|
type CustomCommands struct {
|
|
*GitCommon
|
|
}
|
|
|
|
func NewCustomCommands(gitCommon *GitCommon) *CustomCommands {
|
|
return &CustomCommands{
|
|
GitCommon: gitCommon,
|
|
}
|
|
}
|
|
|
|
// Only to be used for the sake of running custom commands specified by the user.
|
|
// If you want to run a new command, try finding a place for it in one of the neighbouring
|
|
// files, or creating a new BlahCommands struct to hold it.
|
|
func (self *CustomCommands) RunWithOutput(cmdStr string) (string, error) {
|
|
return self.cmd.New(str.ToArgv(cmdStr)).RunWithOutput()
|
|
}
|