diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 5f54209a..038ed624 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -13,7 +13,7 @@ jobs: runs-on: ubuntu-latest env: GO_VERSION: stable - GOLANGCI_LINT_VERSION: v1.58.1 + GOLANGCI_LINT_VERSION: v1.59.0 HUGO_VERSION: 0.117.0 CGO_ENABLED: 0 LEGO_E2E_TESTS: CI diff --git a/.golangci.yml b/.golangci.yml index 16750641..d62ad647 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -152,6 +152,10 @@ issues: - funlen - goconst - maintidx + - path: (.+)_test.go + text: 'Error return value of `fmt.Fprintln` is not checked' + linters: + - errcheck - path: providers/dns/dns_providers.go linters: - gocyclo diff --git a/providers/dns/dynu/internal/client_test.go b/providers/dns/dynu/internal/client_test.go index 7f33bc2c..6819310f 100644 --- a/providers/dns/dynu/internal/client_test.go +++ b/providers/dns/dynu/internal/client_test.go @@ -106,7 +106,7 @@ func TestGetRootDomain(t *testing.T) { require.NoError(t, err) - assert.NotNil(t, domain) + assert.NotNil(t, domain) //nolint:testifylint // false positive https://github.com/Antonboom/testifylint/issues/95 assert.Equal(t, test.expected.domain, domain) }) } diff --git a/providers/dns/rcodezero/internal/client_test.go b/providers/dns/rcodezero/internal/client_test.go index c19e6e5b..09678608 100644 --- a/providers/dns/rcodezero/internal/client_test.go +++ b/providers/dns/rcodezero/internal/client_test.go @@ -74,7 +74,7 @@ func TestClient_UpdateRecords_error(t *testing.T) { resp, err := client.UpdateRecords(context.Background(), "example.org", rrSet) require.ErrorAs(t, err, new(*APIResponse)) - assert.Nil(t, resp) + assert.Nil(t, resp) //nolint:testifylint // false positive https://github.com/Antonboom/testifylint/issues/95 } func TestClient_UpdateRecords(t *testing.T) { diff --git a/providers/dns/servercow/internal/client_test.go b/providers/dns/servercow/internal/client_test.go index 8597d7e1..48464928 100644 --- a/providers/dns/servercow/internal/client_test.go +++ b/providers/dns/servercow/internal/client_test.go @@ -151,7 +151,7 @@ func TestClient_CreateUpdateRecord_error(t *testing.T) { msg, err := client.CreateUpdateRecord(context.Background(), "lego.wtf", record) require.Error(t, err) - assert.Nil(t, msg) + assert.Nil(t, msg) //nolint:testifylint // false positive https://github.com/Antonboom/testifylint/issues/95 } func TestClient_DeleteRecord(t *testing.T) { @@ -218,5 +218,5 @@ func TestClient_DeleteRecord_error(t *testing.T) { msg, err := client.DeleteRecord(context.Background(), "lego.wtf", record) require.Error(t, err) - assert.Nil(t, msg) + assert.Nil(t, msg) //nolint:testifylint // false positive https://github.com/Antonboom/testifylint/issues/95 }