mirror of
https://github.com/go-acme/lego.git
synced 2024-12-03 19:16:42 +02:00
47219adc00
Different DNS providers were handling credentials in different ways. Some were reading credential environment variables in cli_handlers.go and then passing them into the NewDNSProvider function, while others were reading the environment variables within their NewDNSProvider functions. This change replaces each DNS challenge's NewDNSProvider function with two new functions: (1) a NewDNSProvider function that takes no parameters and uses the environment to read credentials, and (2) a NewDNSProviderCredentials that takes credentials as parameters.
86 lines
1.8 KiB
Go
86 lines
1.8 KiB
Go
package googlecloud
|
|
|
|
import (
|
|
"os"
|
|
"testing"
|
|
"time"
|
|
|
|
"golang.org/x/net/context"
|
|
"golang.org/x/oauth2/google"
|
|
"google.golang.org/api/dns/v1"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
var (
|
|
gcloudLiveTest bool
|
|
gcloudProject string
|
|
gcloudDomain string
|
|
)
|
|
|
|
func init() {
|
|
gcloudProject = os.Getenv("GCE_PROJECT")
|
|
gcloudDomain = os.Getenv("GCE_DOMAIN")
|
|
_, err := google.DefaultClient(context.Background(), dns.NdevClouddnsReadwriteScope)
|
|
if err == nil && len(gcloudProject) > 0 && len(gcloudDomain) > 0 {
|
|
gcloudLiveTest = true
|
|
}
|
|
}
|
|
|
|
func restoreGCloudEnv() {
|
|
os.Setenv("GCE_PROJECT", gcloudProject)
|
|
}
|
|
|
|
func TestNewDNSProviderValid(t *testing.T) {
|
|
if !gcloudLiveTest {
|
|
t.Skip("skipping live test (requires credentials)")
|
|
}
|
|
os.Setenv("GCE_PROJECT", "")
|
|
_, err := NewDNSProviderCredentials("my-project")
|
|
assert.NoError(t, err)
|
|
restoreGCloudEnv()
|
|
}
|
|
|
|
func TestNewDNSProviderValidEnv(t *testing.T) {
|
|
if !gcloudLiveTest {
|
|
t.Skip("skipping live test (requires credentials)")
|
|
}
|
|
os.Setenv("GCE_PROJECT", "my-project")
|
|
_, err := NewDNSProvider()
|
|
assert.NoError(t, err)
|
|
restoreGCloudEnv()
|
|
}
|
|
|
|
func TestNewDNSProviderMissingCredErr(t *testing.T) {
|
|
os.Setenv("GCE_PROJECT", "")
|
|
_, err := NewDNSProvider()
|
|
assert.EqualError(t, err, "Google Cloud project name missing")
|
|
restoreGCloudEnv()
|
|
}
|
|
|
|
func TestLiveGoogleCloudPresent(t *testing.T) {
|
|
if !gcloudLiveTest {
|
|
t.Skip("skipping live test")
|
|
}
|
|
|
|
provider, err := NewDNSProviderCredentials(gcloudProject)
|
|
assert.NoError(t, err)
|
|
|
|
err = provider.Present(gcloudDomain, "", "123d==")
|
|
assert.NoError(t, err)
|
|
}
|
|
|
|
func TestLiveGoogleCloudCleanUp(t *testing.T) {
|
|
if !gcloudLiveTest {
|
|
t.Skip("skipping live test")
|
|
}
|
|
|
|
time.Sleep(time.Second * 1)
|
|
|
|
provider, err := NewDNSProviderCredentials(gcloudProject)
|
|
assert.NoError(t, err)
|
|
|
|
err = provider.CleanUp(gcloudDomain, "", "123d==")
|
|
assert.NoError(t, err)
|
|
}
|